Closed Bug 772976 Opened 12 years ago Closed 6 years ago

memory profiler + gcstats = unusable vm (probably b/c of GCLog/gclog confusion)

Categories

(Tamarin Graveyard :: Garbage Collection (mmGC), defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: pnkfelix, Unassigned)

Details

If seems if one combines MMGC_MEMORY_PROFILER (a #define in MMgc.h) with GCOption=-memstats (i.e. passing -memstats on the avmshell invocation) then you end up with an unusable runtime because it prints a full memory profile not only on every sweep and every reap but also on every *incremental mark* (see end of GC::IncrementalMark() method). This is no good. I think it could have been an accident (because the GC class defines a gclog(..) method that has the same interface as the GCLog(..) function in MMgc but where gclog(..) has a very different effect). Or maybe one was never intended to be running -memstats and the memory profiler at the same time; but it seems like a ridiculous situation to me. We should consider making the runtime semi-usable even when both these internal dev features are turned on. E.g., by not printing the full memory profile on every IncrementalMark. We should also consider alpha-renaming gclog(..) and/or GCLog(..); (that would be a separate bug from this; I'm just making a note for the future).
Tamarin isn't maintained anymore. WONTFIX remaining bugs.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.