772993 - Compiler warnings in widget/android

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

/home/kats/zspace/mozilla-git/widget/android/AndroidJavaWrappers.cpp: In member function 'void mozilla::AndroidGeckoEvent::ReadPointArray(nsTArray<nsIntPoint>&, JNIEnv*, _jfieldID*, PRUint32)':
/home/kats/zspace/mozilla-git/widget/android/AndroidJavaWrappers.cpp:310: warning: comparison between signed and unsigned integer expressions
/home/kats/zspace/mozilla-git/widget/android/AndroidJavaWrappers.cpp: In member function 'void mozilla::AndroidGeckoEvent::ReadIntArray(nsTArray<int>&, JNIEnv*, _jfieldID*, PRUint32)':
/home/kats/zspace/mozilla-git/widget/android/AndroidJavaWrappers.cpp:327: warning: comparison between signed and unsigned integer expressions
/home/kats/zspace/mozilla-git/widget/android/AndroidJavaWrappers.cpp: In member function 'void mozilla::AndroidGeckoEvent::ReadFloatArray(nsTArray<float>&, JNIEnv*, _jfieldID*, PRUint32)':
/home/kats/zspace/mozilla-git/widget/android/AndroidJavaWrappers.cpp:341: warning: comparison between signed and unsigned integer expressions


/home/kats/zspace/mozilla-git/widget/android/nsAppShell.cpp: In constructor 'ScreenshotRunnable::ScreenshotRunnable(nsIAndroidBrowserApp*, int, nsTArray<nsIntPoint>&, int, mozilla::RefCountedJavaObject*)':
/home/kats/zspace/mozilla-git/widget/android/nsAppShell.cpp:94: warning: 'ScreenshotRunnable::mTabId' will be initialized after
/home/kats/zspace/mozilla-git/widget/android/nsAppShell.cpp:93: warning:   'nsTArray<nsIntPoint> ScreenshotRunnable::mPoints'
/home/kats/zspace/mozilla-git/widget/android/nsAppShell.cpp:72: warning:   when initialized here
/home/kats/zspace/mozilla-git/widget/android/nsAppShell.cpp: In member function 'void nsAppShell::PostEvent(mozilla::AndroidGeckoEvent*)':
/home/kats/zspace/mozilla-git/widget/android/nsAppShell.cpp:684: warning: comparison between signed and unsigned integer expressions
/home/kats/zspace/mozilla-git/widget/android/AndroidBridge.cpp: In member function 'void mozilla::AndroidBridge::GetSystemColors(mozilla::AndroidSystemColors*)':
/home/kats/zspace/mozilla-git/widget/android/AndroidBridge.cpp:1020: warning: comparison between signed and unsigned integer expressions
/home/kats/zspace/mozilla-git/widget/android/AndroidBridge.cpp:1030: warning: suggest parentheses around arithmetic in operand of '|'
/home/kats/zspace/mozilla-git/widget/android/AndroidBridge.cpp: In member function 'void mozilla::AndroidBridge::GetIconForExtension(const nsACString_internal&, PRUint32, PRUint8*)':
/home/kats/zspace/mozilla-git/widget/android/AndroidBridge.cpp:1067: warning: comparison between signed and unsigned integer expressions
/home/kats/zspace/mozilla-git/widget/android/AndroidBridge.cpp:1068: warning: comparison between signed and unsigned integer expressions
/home/kats/zspace/mozilla-git/widget/android/AndroidBridge.cpp: In member function 'bool mozilla::AndroidBridge::ValidateBitmap(_jobject*, int, int)':
/home/kats/zspace/mozilla-git/widget/android/AndroidBridge.cpp:1521: warning: comparison between signed and unsigned integer expressions
/home/kats/zspace/mozilla-git/widget/android/AndroidBridge.cpp:1521: warning: comparison between signed and unsigned integer expressions
/home/kats/zspace/mozilla-git/widget/android/AndroidBridge.cpp: In member function 'bool mozilla::AndroidBridge::LockWindow(void*, unsigned char**, int*, int*, int*, int*)':
/home/kats/zspace/mozilla-git/widget/android/AndroidBridge.cpp:1979: warning: 'typedef' was ignored in this declaration

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

since i'm waiting for a build anyway...

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Pushed to try at https://tbpl.mozilla.org/?tree=Try&rev=df3bee014ce9 to make sure nothing breaks

Comment 3

[Chris Peterson [:cpeterson]]

Comment on attachment 641169 [details] [diff] [review]
Patch

LGTM. These warnings have been bugging me, too. :)

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/641a641e3903

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/641a641e3903