Closed Bug 773055 Opened 10 years ago Closed 10 years ago

Don't allow silent access to appcache for non-app content

Categories

(Firefox OS Graveyard :: General, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: ladamski, Unassigned)

References

Details

Myk brought up in bug 767807 that B2G has disabled prompts for appcache access (https://hg.mozilla.org/mozilla-central/file/340764f48ed2/b2g/app/b2g.js#l31).  This seems wrong.  We should only allow silent appacache access for installed apps, not for non-app content (i.e. within the browser or for non-app content in trusted or certified apps).
Summary: Don't allow silent access to appcache for all content → Don't allow silent access to appcache for non-app content
blocking-basecamp: --- → ?
Erm, digging into this further, it looks like B2G doesn't actually pay any attention to that preference.  Instead, it silently fails if the document doesn't already have the offline-app permission:

http://hg.mozilla.org/mozilla-central/file/70d92a6ccdfa/b2g/chrome/content/shell.js#l264

And bug 710729 is about adding a UI to handle appcache requests.

So B2G does not allow silent access to appcache for non-app content, as I thought it did.  Nor does it appear to intend to do so in the future.

In which case I recommend removing the offline-apps.allow_by_default default pref (or setting it to false), since otherwise it's too easy to accidentally turn on appcache for all content by adding code like Firefox's to honor the pref:

http://hg.mozilla.org/mozilla-central/file/70d92a6ccdfa/browser/base/content/browser.js#l5766
blocking-basecamp: ? → ---
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.