773085 - Door hangers are not keyboard accessible

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Eitan Isaacson [:eeejay]]

When a doorhanger is shown, arrowing around moves the focus on the items below the doorhanger.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Make door hangers keybaord navigable.

Comment 3

[:Margaret Leibovic]

Comment on attachment 641256 [details] [diff] [review]
Make door hangers keybaord navigable.

I don't see this patch causing any problems, but does it also let you navigate to the checkbox and buttons in the doorhanger? I'm not sure how keyboard navigation works, but I'd want to make sure users can interact with those other items.

Comment 4

[Marco Zehe (:MarcoZ)]

Comment on attachment 641256 [details] [diff] [review]
Make door hangers keybaord navigable.

Margaret, this patch only makes such items that aren't focusable by default focusable, too. The checkbox and buttons are focusable by default. This just makes sure the text view is as well, and thus reachable via a directional controller or bluetooth keyboard.

Comment 5

[Eitan Isaacson [:eeejay]]

Yes, you could navigate to the controls. I made the TextView focusable too so the user could navigate to it as well and have it read.

Comment 6

[:Margaret Leibovic]

Thanks for clarifying! I'm glad to hear the buttons and checkbox are focusable by default.

Comment 7

[Eitan Isaacson [:eeejay]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/54cfa52ffb78

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/54cfa52ffb78

Comment 9

[Marco Zehe (:MarcoZ)]

Comment on attachment 641256 [details] [diff] [review]
Make door hangers keybaord navigable.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Neglegance to make the text view that contains the doorhanger question focusable.
User impact if declined: TalkBack users using a keyboard only will not be able to read the question asked by a doorhanger. Affects all Gingerbread users.
Testing completed (on m-c, etc.): Yes, on a local build.
Risk to taking this patch (and alternatives if risky): None.
String or UUID changes made by this patch: None.

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 641256 [details] [diff] [review]
Make door hangers keybaord navigable.

[Triage Comment]
Approved for FF15 given that the a11y reward outweighs the near-zero risk to a non-a11y user.

Comment 11

[Marco Zehe (:MarcoZ)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/caca38771162

Comment 12

[Xiao Meng Wei :xwei]

Verified on Xperia mini pro on password door hanger.