Last Comment Bug 773090 - [Mac] Image map are broken
: [Mac] Image map are broken
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla17
Assigned To: Hubert Figuiere [:hub]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-11 16:33 PDT by Hubert Figuiere [:hub]
Modified: 2012-07-17 02:11 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Implement image map properly on Mac and fix AXLink attributes. r= (1.48 KB, patch)
2012-07-11 17:22 PDT, Hubert Figuiere [:hub]
dbolter: review+
Details | Diff | Splinter Review

Description Hubert Figuiere [:hub] 2012-07-11 16:33:58 PDT
Image map image should be ignored, because what matter are the links. This is on Mac side.

Sample site: http://www.windmobile.ca/en/Pages/default.aspx
Comment 1 David Bolter [:davidb] 2012-07-11 16:37:01 PDT
Hmmm. You sound more confident about this that I am.
Comment 2 Hubert Figuiere [:hub] 2012-07-11 16:39:21 PDT
and in the same example the link as the title for the "shape" attribute from the image map.
Comment 3 j.j. 2012-07-11 16:57:11 PDT
Planned changes in bug 607267 might be related
Comment 4 Hubert Figuiere [:hub] 2012-07-11 17:09:19 PDT
(In reply to j.j. (inactive in 2012) from comment #3)
> Planned changes in bug 607267 might be related

Nah I don't think it is as the internal accessibles are fine. it is just mapping issues between our Accessibles and the Mac side.
Comment 5 Hubert Figuiere [:hub] 2012-07-11 17:22:36 PDT
Created attachment 641277 [details] [diff] [review]
Implement image map properly on Mac and fix AXLink attributes. r=
Comment 6 David Bolter [:davidb] 2012-07-16 11:57:38 PDT
Comment on attachment 641277 [details] [diff] [review]
Implement image map properly on Mac and fix AXLink attributes. r=

Review of attachment 641277 [details] [diff] [review]:
-----------------------------------------------------------------

Seems odd but okay if this is expected on Mac r=me. Don't we have mochitests that will break?
Comment 8 Hubert Figuiere [:hub] 2012-07-16 16:54:50 PDT
> Seems odd but okay if this is expected on Mac r=me. Don't we have mochitests
> that will break?

No because mochitests don't run at that level. The role change is was VO expect.
Comment 9 David Bolter [:davidb] 2012-07-16 19:30:34 PDT
(In reply to Hub Figuiere [:hub] from comment #8)
> > Seems odd but okay if this is expected on Mac r=me. Don't we have mochitests
> > that will break?
> 
> No because mochitests don't run at that level. The role change is was VO
> expect.

/me facepalms

Right.
Comment 10 Hubert Figuiere [:hub] 2012-07-16 21:14:33 PDT
now, to be honest, I'd love to have this kind of stuff tested.
Comment 11 Ed Morley [:emorley] 2012-07-17 02:11:46 PDT
https://hg.mozilla.org/mozilla-central/rev/646c10f2b4f6

Note You need to log in before you can comment on or make changes to this bug.