Closed Bug 773115 Opened 11 years ago Closed 11 years ago

CheckStrictParameters: remove superfluous sc->needStrictChecks()

Categories

(Core :: JavaScript Engine, enhancement)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla16

People

(Reporter: Benjamin, Assigned: Benjamin)

Details

(Whiteboard: [js:t])

Attachments

(1 file)

remove the check
1.00 KB, patch
n.nethercote
: review+
Details | Diff | Splinter Review 
This is done at the top of the function, so it's always true.
Attached patch remove the check — — Splinter Review 
Assignee: general → bpeterson

        Attachment #641297 -
        Flags: review?(n.nethercote)

    
    

    
  
Comment on attachment 641297 [details] [diff] [review]
remove the check

Review of attachment 641297 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for pointing out that it's done at the top of the function;  that makes reviewing a patch like this (where part of the relevant code isn't contained in the patch) much easier.

        Attachment #641297 -
        Flags: review?(n.nethercote) → review+

    
  
Keywords: checkin-needed
Whiteboard: [js:t]

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/0091488ce2f1
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16

          You need to log in
          before you can comment on or make changes to this bug.