Closed
Bug 773115
Opened 14 years ago
Closed 14 years ago
CheckStrictParameters: remove superfluous sc->needStrictChecks()
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: Benjamin, Assigned: Benjamin)
Details
(Whiteboard: [js:t])
Attachments
(1 file)
|
1.00 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
This is done at the top of the function, so it's always true.
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: general → bpeterson
Attachment #641297 -
Flags: review?(n.nethercote)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 641297 [details] [diff] [review]
remove the check
Review of attachment 641297 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for pointing out that it's done at the top of the function; that makes reviewing a patch like this (where part of the relevant code isn't contained in the patch) much easier.
Attachment #641297 -
Flags: review?(n.nethercote) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
||
Updated•14 years ago
|
Whiteboard: [js:t]
|
||
Comment 3•14 years ago
|
||
Flags: in-testsuite-
Keywords: checkin-needed
|
|
||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in
before you can comment on or make changes to this bug.
Description
•