The default bug view has changed. See this FAQ.

CheckStrictParameters: remove superfluous sc->needStrictChecks()

RESOLVED FIXED in mozilla16

Status

()

Core
JavaScript Engine
--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Benjamin, Assigned: Benjamin)

Tracking

unspecified
mozilla16
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
This is done at the top of the function, so it's always true.
(Assignee)

Comment 1

5 years ago
Created attachment 641297 [details] [diff] [review]
remove the check
Assignee: general → bpeterson
Attachment #641297 - Flags: review?(n.nethercote)
Comment on attachment 641297 [details] [diff] [review]
remove the check

Review of attachment 641297 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for pointing out that it's done at the top of the function;  that makes reviewing a patch like this (where part of the relevant code isn't contained in the patch) much easier.
Attachment #641297 - Flags: review?(n.nethercote) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Whiteboard: [js:t]
https://hg.mozilla.org/integration/mozilla-inbound/rev/0091488ce2f1
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0091488ce2f1
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.