Closed Bug 773115 Opened 9 years ago Closed 9 years ago

CheckStrictParameters: remove superfluous sc->needStrictChecks()

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: Benjamin, Assigned: Benjamin)

Details

(Whiteboard: [js:t])

Attachments

(1 file)

This is done at the top of the function, so it's always true.
Attached patch remove the checkSplinter Review
Assignee: general → bpeterson
Attachment #641297 - Flags: review?(n.nethercote)
Comment on attachment 641297 [details] [diff] [review]
remove the check

Review of attachment 641297 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for pointing out that it's done at the top of the function;  that makes reviewing a patch like this (where part of the relevant code isn't contained in the patch) much easier.
Attachment #641297 - Flags: review?(n.nethercote) → review+
Keywords: checkin-needed
Whiteboard: [js:t]
https://hg.mozilla.org/mozilla-central/rev/0091488ce2f1
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.