Last Comment Bug 773115 - CheckStrictParameters: remove superfluous sc->needStrictChecks()
: CheckStrictParameters: remove superfluous sc->needStrictChecks()
Status: RESOLVED FIXED
[js:t]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- enhancement (vote)
: mozilla16
Assigned To: :Benjamin Peterson
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-11 18:06 PDT by :Benjamin Peterson
Modified: 2012-07-13 05:30 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
remove the check (1.00 KB, patch)
2012-07-11 18:07 PDT, :Benjamin Peterson
n.nethercote: review+
Details | Diff | Splinter Review

Description :Benjamin Peterson 2012-07-11 18:06:21 PDT
This is done at the top of the function, so it's always true.
Comment 1 :Benjamin Peterson 2012-07-11 18:07:15 PDT
Created attachment 641297 [details] [diff] [review]
remove the check
Comment 2 Nicholas Nethercote [:njn] 2012-07-11 19:34:22 PDT
Comment on attachment 641297 [details] [diff] [review]
remove the check

Review of attachment 641297 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for pointing out that it's done at the top of the function;  that makes reviewing a patch like this (where part of the relevant code isn't contained in the patch) much easier.
Comment 3 Ryan VanderMeulen [:RyanVM] 2012-07-12 16:39:26 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/0091488ce2f1
Comment 4 Ed Morley [:emorley] 2012-07-13 05:30:36 PDT
https://hg.mozilla.org/mozilla-central/rev/0091488ce2f1

Note You need to log in before you can comment on or make changes to this bug.