Last Comment Bug 773143 - Rename MOZ_ANGLE to MOZ_ANGLE_RENDERER [Port |Bug 772457 Remove compile-time option to disable ANGLE, replace it by an option to disable WebGL altogether (also disabling ANGLE)|]
: Rename MOZ_ANGLE to MOZ_ANGLE_RENDERER [Port |Bug 772457 Remove compile-time...
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 19.0
Assigned To: Jens Hatlak (:InvisibleSmiley)
:
Mentors:
http://mxr.mozilla.org/comm-central/s...
: 773538 (view as bug list)
Depends on: 772457
Blocks: 803168
  Show dependency treegraph
 
Reported: 2012-07-11 21:07 PDT by Philip Chee
Modified: 2012-11-10 07:31 PST (History)
1 user (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
-


Attachments
part 1: rename [Checkin: Comment 8] (7.12 KB, patch)
2012-11-04 09:25 PST, Jens Hatlak (:InvisibleSmiley)
bugspam.Callek: review+
Details | Diff | Splinter Review
part 2: rest [Checkin: Comment 9] (7.51 KB, patch)
2012-11-04 09:26 PST, Jens Hatlak (:InvisibleSmiley)
bugspam.Callek: review+
Details | Diff | Splinter Review

Description Philip Chee 2012-07-11 21:07:04 PDT

    
Comment 2 Philip Chee 2012-07-11 21:22:10 PDT
Do we need to change these comm-central files as well?
config/autoconf.mk.in
configure.in
Comment 3 Serge Gautherie (:sgautherie) 2012-07-12 05:14:28 PDT
(In reply to Philip Chee from comment #2)
> Do we need to change these comm-central files as well?
> config/autoconf.mk.in
> configure.in

Yes.
Comment 4 Serge Gautherie (:sgautherie) 2012-07-13 09:02:25 PDT
*** Bug 773538 has been marked as a duplicate of this bug. ***
Comment 5 Mark Banner (:standard8) 2012-07-31 03:07:01 PDT
Please explain why you think we should track a bug when requesting tracking.

In this case, I can't see anything that needs to be tracked here - the defaults will still work for the standard Thunderbird configuration. For users using non-standard configs, they might need to specify two options rather than one, but that's not something worth tracking. If someone ports this, then I'd accept a patch to have it synchronised, but I'm not going to direct effort onto it specifically.
Comment 6 Jens Hatlak (:InvisibleSmiley) 2012-11-04 09:25:01 PST
Created attachment 678134 [details] [diff] [review]
part 1: rename [Checkin: Comment 8]

I'm attaching two patches, one with the simple renaming (which will need no real review or discussion) and another one on top of the first that ports the extra bits from bug 772457 and some follow-up bugs concerning the same configure.in section. If it's decided that the latter one should have its own set of bugs or not be done at all, at least the first part won't be lost work.

Please note that I'm not a build system expert or anything close to that; I just felt this should be done rather sooner than later.
Comment 7 Jens Hatlak (:InvisibleSmiley) 2012-11-04 09:26:11 PST
Created attachment 678135 [details] [diff] [review]
part 2: rest [Checkin: Comment 9]

[Feel free to add or change reviewers as necessary.]
Comment 8 Jens Hatlak (:InvisibleSmiley) 2012-11-10 07:29:27 PST
Comment on attachment 678134 [details] [diff] [review]
part 1: rename [Checkin: Comment 8]

http://hg.mozilla.org/comm-central/rev/84173f8837f7
Comment 9 Jens Hatlak (:InvisibleSmiley) 2012-11-10 07:30:52 PST
Comment on attachment 678135 [details] [diff] [review]
part 2: rest [Checkin: Comment 9]

http://hg.mozilla.org/comm-central/rev/afdbfb6acd3c
(with anti-bitrot for the first configure.in hunk)

Note You need to log in before you can comment on or make changes to this bug.