Closed Bug 773143 Opened 8 years ago Closed 7 years ago

Rename MOZ_ANGLE to MOZ_ANGLE_RENDERER [Port |Bug 772457 Remove compile-time option to disable ANGLE, replace it by an option to disable WebGL altogether (also disabling ANGLE)|]

Categories

(MailNews Core :: Build Config, defect)

defect
Not set

Tracking

(thunderbird16-)

RESOLVED FIXED
Thunderbird 19.0
Tracking Status
thunderbird16 - ---

People

(Reporter: philip.chee, Assigned: InvisibleSmiley)

References

(Blocks 1 open bug, )

Details

Attachments

(2 files)

No description provided.
https://hg.mozilla.org/mozilla-central/rev/3391c610940b#l1.12
https://hg.mozilla.org/mozilla-central/rev/3391c610940b#l2.12
Summary: Rename MOZ_ANGLE is renamed to MOZ_ANGLE_RENDERER [Port |Bug 772457 Remove compile-time option to disable ANGLE, replace it by an option to disable WebGL altogether (also disabling ANGLE)|] → Rename MOZ_ANGLE to MOZ_ANGLE_RENDERER [Port |Bug 772457 Remove compile-time option to disable ANGLE, replace it by an option to disable WebGL altogether (also disabling ANGLE)|]
Do we need to change these comm-central files as well?
config/autoconf.mk.in
configure.in
(In reply to Philip Chee from comment #2)
> Do we need to change these comm-central files as well?
> config/autoconf.mk.in
> configure.in

Yes.
Assignee: installer → nobody
Component: Installer → Build Config
Depends on: 772457
Flags: in-testsuite-
Product: SeaMonkey → MailNews Core
Duplicate of this bug: 773538
Please explain why you think we should track a bug when requesting tracking.

In this case, I can't see anything that needs to be tracked here - the defaults will still work for the standard Thunderbird configuration. For users using non-standard configs, they might need to specify two options rather than one, but that's not something worth tracking. If someone ports this, then I'd accept a patch to have it synchronised, but I'm not going to direct effort onto it specifically.
Blocks: 803168
I'm attaching two patches, one with the simple renaming (which will need no real review or discussion) and another one on top of the first that ports the extra bits from bug 772457 and some follow-up bugs concerning the same configure.in section. If it's decided that the latter one should have its own set of bugs or not be done at all, at least the first part won't be lost work.

Please note that I'm not a build system expert or anything close to that; I just felt this should be done rather sooner than later.
Assignee: nobody → jh
Status: NEW → ASSIGNED
Attachment #678134 - Flags: review?(bugspam.Callek)
[Feel free to add or change reviewers as necessary.]
Attachment #678135 - Flags: review?(bugspam.Callek)
Attachment #678134 - Flags: review?(bugspam.Callek) → review+
Attachment #678135 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 678134 [details] [diff] [review]
part 1: rename [Checkin: Comment 8]

http://hg.mozilla.org/comm-central/rev/84173f8837f7
Attachment #678134 - Attachment description: part 1: rename → part 1: rename [Checkin: Comment 8]
Comment on attachment 678135 [details] [diff] [review]
part 2: rest [Checkin: Comment 9]

http://hg.mozilla.org/comm-central/rev/afdbfb6acd3c
(with anti-bitrot for the first configure.in hunk)
Attachment #678135 - Attachment description: part 2: rest → part 2: rest [Checkin: Comment 9]
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in before you can comment on or make changes to this bug.