773161 - Intermittent browser_gcli_addon.js | Test timed out

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=13448305&tree=Mozilla-Inbound
Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound opt test mochitest-other on 2012-07-11 21:55:06 PDT for push 264e13c78fee
slave: talos-r4-snow-079

TEST-START | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_addon.js
error
  In screenshot/fullpage: boolean parameters can not have a defaultValue. Ignoring
error
  In restart/nocache: boolean parameters can not have a defaultValue. Ignoring
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_addon.js | Test timed out
(screenshot)
warn: Failed to remove handler from Inputter.onResize
warn: Failed to remove handler from CommandAssignment.onAssignmentChange
INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_addon.js | finished in 30066ms

Comment 1

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=13454975&tree=Mozilla-Inbound
Rev3 WINNT 6.1 mozilla-inbound pgo test mochitest-other on 2012-07-12 03:36:33
slave: talos-r3-w7-042

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_addon.js | Test timed out

Comment 2

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=13535759&tree=Profiling
Rev3 WINNT 5.1 profiling opt test mochitest-other on 2012-07-14 10:53:31
slave: talos-r3-xp-017

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_addon.js | Test timed out

Comment 3

[Legacy TBPL/Treeherder Robot]

ehsan
https://tbpl.mozilla.org/php/getParsedLog.php?id=13591889&tree=Mozilla-Inbound
Rev3 Fedora 12x64 mozilla-inbound opt test mochitest-other on 2012-07-16 19:36:40
slave: talos-r3-fed64-061

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_addon.js | Test timed out

Comment 4

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=13604511&tree=Mozilla-Aurora
Rev3 WINNT 6.1 mozilla-aurora pgo test mochitest-other on 2012-07-17 07:37:26
slave: talos-r3-w7-029

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_addon.js | Test timed out

Comment 5

[Legacy TBPL/Treeherder Robot]

ryanvm%gmail.com
https://tbpl.mozilla.org/php/getParsedLog.php?id=13757719&tree=Birch
Rev3 WINNT 5.1 birch opt test mochitest-other on 2012-07-22 12:07:05
slave: talos-r3-xp-039

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_464620_b.js | an unexpected uncaught JS exception reported through window.onerror - ReferenceError: setup is not defined at http://mochi.test:8888/browser/browser/components/sessionstore/test/browser_464620_b.html:1
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_464620_b.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_464620_b.js | Found a tab after previous test timed out: http://mochi.test:8888/browser/browser/components/sessionstore/test/browser_464620_b.html
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_addon.js | Test timed out

Comment 6

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=13871712&tree=Mozilla-Aurora
Rev3 MacOSX Leopard 10.5.8 mozilla-aurora opt test mochitest-other on 2012-07-26 05:00:09
slave: talos-r3-leopard-013

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_addon.js | Test timed out

Comment 7

[Legacy TBPL/Treeherder Robot]

ttaubert
https://tbpl.mozilla.org/php/getParsedLog.php?id=14194789&tree=Try
Rev3 Fedora 12x64 try opt test mochitest-other on 2012-08-07 10:04:42
slave: talos-r3-fed64-018

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_addon.js | Test timed out

Comment 8

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=14261762&tree=Mozilla-Aurora
Rev3 WINNT 6.1 mozilla-aurora pgo test mochitest-other on 2012-08-09 08:00:29
slave: talos-r3-w7-007

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_addon.js | Test timed out

Comment 9

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=14498016&tree=Mozilla-Aurora
Rev3 WINNT 6.1 mozilla-aurora pgo test mochitest-other on 2012-08-18 07:24:44
slave: talos-r3-w7-033

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_addon.js | Test timed out

Comment 10

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=14509347&tree=Mozilla-Aurora
Rev3 WINNT 6.1 mozilla-aurora pgo test mochitest-other on 2012-08-19 07:24:28
slave: talos-r3-w7-049

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_addon.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_createRemote.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_createRemote.js | Found a  after previous test timed out

Comment 11

[Legacy TBPL/Treeherder Robot]

mbrubeck
https://tbpl.mozilla.org/php/getParsedLog.php?id=14528430&tree=Mozilla-Aurora
Rev3 WINNT 6.1 mozilla-aurora pgo test mochitest-other on 2012-08-20 07:33:30
slave: talos-r3-w7-036

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_addon.js | Test timed out

Comment 12

[Legacy TBPL/Treeherder Robot]

paul
https://tbpl.mozilla.org/php/getParsedLog.php?id=14697347&tree=Try
Rev3 WINNT 5.1 try opt test mochitest-other on 2012-08-25 02:02:43
slave: talos-r3-xp-067

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_addon.js | Test timed out

Comment 13

[Joe Walker [:jwalker]]

Mike: What would happen if the addon system called AddonManager.getAllAddons very late? Like after the tests had started running?

Perhaps this is a result of lack of async types?

Comment 14

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

At the end of our call to getAllAddons we send a notification (gcli_addon_commands_ready) and the tests do not begin until this notification is received.

I suspect that this issue is caused by the command completing it's loading before the test is run (getAllAddons is running too early). We need the gcli_addon_commands_ready notification so that we know when getAllAddons finishes running, I guess we need some way to know if getAllAddons has already run.

Comment 15

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Added gcli.addonsLoaded to determine whether getAllAddons is already complete

I have added a gcli.addonsLoaded flag so that we can fire a gcli_addon_commands_ready notification in the event that one was sent before the test started running.

Comment 16

[Joe Walker [:jwalker]]

Comment on attachment 655945 [details] [diff] [review]
Added gcli.addonsLoaded to determine whether getAllAddons is already complete

Review of attachment 655945 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/commandline/test/browser_cmd_addon.js
@@ +96,5 @@
>    });
>  
>    Services.obs.addObserver(GAT_ready, "gcli_addon_commands_ready", false);
> +
> +  if (imported.gcli.addonsLoaded) {

I like it except that we're using GCLI as a place to store a flag that is of use only to the addon command.

Would it work to use an object exported from CmdAddon to store this flag?

Comment 17

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Moved addonsLoaded flag into CmdAddon.jsm

Comment 18

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Removed extra comment

Comment 19

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=14966352&tree=Mozilla-Beta
Rev3 WINNT 5.1 mozilla-beta pgo test mochitest-other on 2012-09-04 21:22:06
slave: talos-r3-xp-056

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_addon.js | Test timed out

Comment 20

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=15118377&tree=Mozilla-Beta
Rev3 WINNT 6.1 mozilla-beta debug test mochitest-other on 2012-09-10 17:44:54
slave: talos-r3-w7-005

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_addon.js | Test timed out

Comment 21

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/6bf80ef6905d

Comment 22

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/mozilla-central/rev/6bf80ef6905d