773167 - Otoro: 3G Data Call fail on ICS

Status: VERIFIED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

The quirk introduced by bug 763160 is not needed on Otoro ICS. We need to find a way to distinguish between Otoro GB and ICS, or remove the quirk in favor of ICS.

Comment 1

[Kan-Ru Chen [:kanru] (UTC+9)]

To enable 3G on Otoro ICS you have to apply this gonk patch

https://github.com/mozilla-b2g/android-device-otoro/pull/7

Comment 2

[Michael Vines [:m1] [:evilmachines]]

We should drop support for Otoro GB, its a dead platform

Comment 3

[John Hammink]

One manifestation we're seeing on ICS based Otoro devices is this: 

https://github.com/mozilla-b2g/gaia/issues/2360

Comment 4

[Philipp von Weitershausen [:philikon]]

vliu, could you take care of this? Thanks!

Comment 5

[Vincent Liu[:vliu]]

Attachment: patch file to remove fix in otoro GB

(In reply to Philipp von Weitershausen [:philikon] from comment #4)
> vliu, could you take care of this? Thanks!

I attached a patch to remove the fix in otoro GB. Please review it. Thanks.

Comment 6

[Philipp von Weitershausen [:philikon]]

Comment on attachment 642348 [details] [diff] [review]
patch file to remove fix in otoro GB

Thanks for the quick patch, vliu! AFAICT we may want to support both GB and ICS for a short period of time, so I'm going to hold off on the r+ for now while we can find out how to support both by detecting which one we're dealing with at runtime.

Comment 7

[Philipp von Weitershausen [:philikon]]

Comment on attachment 642348 [details] [diff] [review]
patch file to remove fix in otoro GB

Erm, never mind, let's just move forward on ICS.

Comment 8

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7fe4e32d8ca3

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7fe4e32d8ca3

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified:
Otoro phone, build 2012-07-26
Taken from default.xml in b2g-distro: 
* "platform_build" revision= 2163d79af8c06ffcf7607a83e01dc5bf1107fd8e
* "gaia" revision= 2a43477715fcbb420f91739a787ac6af3bd857d8
* "mozilla-central" revision= d216f9252c024d8de8cd5e034b9ac28ad5d3391d
* "gonk-misc" revision= c6a9a256cd4a1c53696488739d36778b9dbfc881