Last Comment Bug 773174 - GCLI help output should be sorted
: GCLI help output should be sorted
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: Trunk
: All All
: P1 normal (vote)
: Firefox 16
Assigned To: Joe Walker [:jwalker] (needinfo me or ping on irc)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-12 01:39 PDT by Joe Walker [:jwalker] (needinfo me or ping on irc)
Modified: 2012-07-16 05:27 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (1.50 KB, patch)
2012-07-12 10:44 PDT, Joe Walker [:jwalker] (needinfo me or ping on irc)
fayearthur: review+
Details | Diff | Splinter Review

Description Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-07-12 01:39:36 PDT
commands.sort();
  // Fail

commands.sort(function(c1, c2) {
  return c1.name.localeCompare(c2.name);
});
  // Win
Comment 1 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-07-12 10:44:51 PDT
Created attachment 641529 [details] [diff] [review]
v1

This has already had r+ in https://github.com/harthur/gcli/pull/1
Comment 2 Heather Arthur [:harth] 2012-07-12 10:53:35 PDT
Comment on attachment 641529 [details] [diff] [review]
v1

yep, looks good.
Comment 3 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-07-13 05:01:32 PDT
https://tbpl.mozilla.org/?tree=Try&rev=989a2e09632b
Comment 4 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-07-13 10:27:54 PDT
https://tbpl.mozilla.org/?tree=Fx-Team&rev=e7d2e3c6d861
Comment 5 Ed Morley [:emorley] 2012-07-16 05:27:27 PDT
https://hg.mozilla.org/mozilla-central/rev/acfe6c13a72c

Note You need to log in before you can comment on or make changes to this bug.