Closed
Bug 773192
Opened 11 years ago
Closed 11 years ago
Always requesting compositor DrawToSurface() when using non-default target in content context
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: cjones, Assigned: cjones)
References
Details
Attachments
(1 file)
To the best of my knowledge, we only initiate a txn with non-default target for a BasicShadowableLayerManager when we do drawWindow(USE_WIDGET_LAYERS). This is what we want for reftests with omtc-not-OOP, and it's also what we want for drawWindow() when we're using omtc with only one |window| (as is the case with native fennec). For OOP reftests however, the DrawToSurface() path is horrendously expensive, and unnecessary. (Although it doesn't hurt anything corretness-wise.) It's also wrong with OOP content that's embedded in a |window| in its parent: the DrawToSurface() will snapshot the entire window (AFAICT), not the child |window| that was requested. This would break drawWindow(USE_WIDGET_LAYERS) from within a content process. I don't really care about drawWindow(USE_WIDGET_LAYERS) from content processes outside of reftests, but I don't want to slow down OOP reftests. So I have a patch that only does DrawToSurface() from the top-level process.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee: nobody → jones.chris.g
Attachment #641402 -
Flags: review?(ajuma)
Updated•11 years ago
|
Attachment #641402 -
Flags: review?(ajuma) → review+
Assignee | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f0c3cb6d911
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4f0c3cb6d911
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in
before you can comment on or make changes to this bug.
Description
•