773339 - IonMonkey: Refactor Compile in Ion.cpp to be templated and not use fp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Shu-yu Guo [:shu]]

Attachment: refactor

For RiverTrail implementation we'd like the ability to try to compile a script without invoking it. I would like to reuse the Compile logic for this.

Comment 1

[Shu-yu Guo [:shu]]

The idea is, for instance, be able to write something like a |CanEnterParallelArrayKernel| that then calls |Compile<ParallelArrayKernelCompiler>|.

Comment 2

[Shu-yu Guo [:shu]]

Comment on attachment 641518 [details] [diff] [review]
refactor

Based on patch from bug 773123 already applied.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 641518 [details] [diff] [review]
refactor

Review of attachment 641518 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with these changes:

::: js/src/ion/Ion.cpp
@@ +931,5 @@
>      // This check is to not overrun the stack. Eventually, we will want to
>      // handle this when we support JSOP_ARGUMENTS or function calls.
> +    if (fp->isFunctionFrame() &&
> +        (fp->numActualArgs() >= SNAPSHOT_MAX_NARGS ||
> +         fp->numActualArgs() > js_IonOptions.maxStackArgs)) {

nit: { on newline, for multi-line conditionals.

@@ +1090,5 @@
>          fp->functionThis().setObject(*obj);
>      }
>  
> +    // Skip if frame can't be handled.
> +    if (!CheckFrame(fp))

If this fails, we'll no longer call ForbidCompilation, so each place this is called, we should explicitly call it.

Comment 4

[Shu-yu Guo [:shu]]

http://hg.mozilla.org/projects/ionmonkey/rev/7a13838698ed