773347 - GCLI hidden commands don't execute properly

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Comment 1

[Joe Walker [:jwalker]]

This bug is about fixing the mechanism for hiding bugs. Setting 'hidden:true' on a command or parameter was possible ages ago, but not included in unit tests, so the feature rotted.

The situation was that setting 'hidden:true' correctly removed a command from the completion, but also prevented it's execution because it didn't appear in any 'predictions' and so was marked ERROR.

This brings it back and adds tests.

Comment 2

[Joe Walker [:jwalker]]

Attachment: v1

The changes that you see in https://github.com/harthur/gcli/pull/3 are in this patch in:
- browser/devtools/commandline/gcli.jsm
- browser/devtools/commandline/test/browser_gcli_web.js

(GCLI contains a node script that builds these files from the GCLI sources)

Also this patch includes:
- Make the hidden state of 'cmd refresh' depend on whether the user has set
  the preference to point to a command directory.
- Now that hidden commands can be executed, I've removed the commenting out
  of the tests, so the commands are tested again.

Comment 3

[Heather Arthur [:harth]]

Comment on attachment 642913 [details] [diff] [review]
v1

Review of attachment 642913 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, except for a maybe redundant test.

::: browser/devtools/commandline/test/browser_gcli_web.js
@@ +3071,5 @@
> +  });
> +
> +  helpers.setInput('tshidden');
> +  helpers.check({
> +    input:  'tshidden',

commented on the pull request, but it looks like the exact same test is here twice.

Comment 4

[Joe Walker [:jwalker]]

Attachment: v2

Removed duplicate test

Comment 5

[Joe Walker [:jwalker]]

Attachment: v3

rebase

Comment 6

[Rob Campbell [:rc] (:robcee)]

Backed out in:

https://hg.mozilla.org/integration/fx-team/rev/f4596ef17eed

Comment 7

[Joe Walker [:jwalker]]

Re-land
https://tbpl.mozilla.org/?tree=Fx-Team&rev=c80d0e010be3

Comment 8

[Dave Camp (:dcamp)]

https://hg.mozilla.org/mozilla-central/rev/6b00d1edb2e7

Comment 9

[Dave Camp (:dcamp)]

Oops, https://hg.mozilla.org/mozilla-central/rev/efd1509146d5 was the relanded changeset.