Closed
Bug 773393
Opened 13 years ago
Closed 13 years ago
Move filepicker and activity-result code out of GeckoApp so it survives activity destruction
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox15 fixed)
RESOLVED
FIXED
Firefox 16
Tracking | Status | |
---|---|---|
firefox15 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(3 files, 3 obsolete files)
25.59 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
24.30 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
5.17 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
I started doing this but now my brain is rotting so I don't know if what I'm doing is helping at all. Putting my patches here for now.
Assignee | ||
Comment 1•13 years ago
|
||
Assignee | ||
Comment 2•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Blocks: 769269
Summary: Move filepicker and activity-result code out of GeckoApp → Move filepicker and activity-result code out of GeckoApp so it survives activity destruction
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #641559 -
Attachment is obsolete: true
Attachment #641909 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 4•13 years ago
|
||
Attachment #641560 -
Attachment is obsolete: true
Attachment #641910 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 5•13 years ago
|
||
Attachment #641561 -
Attachment is obsolete: true
Attachment #641911 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 6•13 years ago
|
||
In part 1, when I moved the classes out, there were some minor changes to the code. I'm listing them here for ease of reviewing:
- AwesomebarResultHandler does GeckoApp.mAppContext.loadRequest(...) instead of loadRequest(...)
- Some of the extracted classes take a SynchronousQueue<String> in the constructor and store it locally since they don't have access to the one in GeckoApp directly anymore
- I moved GeckoApp.mImageFilePath to be CameraImageResultHandler.sImageName and updated usage of it accordingly.
In part 2 when I moved the functions out I modified:
- The showFilePicker functions take an "Activity parentActivity" parameter since I needed something on which to call startActivityForResult.
- A lot of the extracted functions now take a Context parameter since there are a couple of functions that need to be called on it (getString in getFilePickerTitle, getPackageManager in addIntentActivitiesToList).
- Renamed AddFilePickingActivities to addFilePickingActivities (case fixup)
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → bugmail.mozilla
Comment 7•13 years ago
|
||
Comment on attachment 641909 [details] [diff] [review]
(1/3) Move GeckoApp inner classes out into their own files
Looks a good, clean port. Nice work.
Attachment #641909 -
Flags: review?(mark.finkle) → review+
Updated•13 years ago
|
Attachment #641910 -
Flags: review?(mark.finkle) → review+
Updated•13 years ago
|
Attachment #641911 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 8•13 years ago
|
||
Comment 9•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f50d3885980b
https://hg.mozilla.org/mozilla-central/rev/e9ba73beb18c
https://hg.mozilla.org/mozilla-central/rev/030cc6de7258
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Comment 10•13 years ago
|
||
status-firefox15:
--- → fixed
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•