Last Comment Bug 773422 - Update pdf.js for FF16
: Update pdf.js for FF16
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: PDF Viewer (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: Firefox 16
Assigned To: Brendan Dahl [:bdahl]
:
Mentors:
Depends on:
Blocks: 762010 778398
  Show dependency treegraph
 
Reported: 2012-07-12 13:39 PDT by Brendan Dahl [:bdahl]
Modified: 2013-04-24 09:57 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
pdf.js 0.3.452 (159.39 KB, patch)
2012-07-12 14:05 PDT, Brendan Dahl [:bdahl]
dtownsend: review+
Details | Diff | Splinter Review
pdf.js 0.3.452 (159.32 KB, patch)
2012-07-13 17:21 PDT, Brendan Dahl [:bdahl]
no flags Details | Diff | Splinter Review

Description Brendan Dahl [:bdahl] 2012-07-12 13:39:56 PDT
#1743 Add viewport metatag for mobile
#1793 Uses ellipsis instead of dots
#1794 Fix fallback after new download.
#1763 Type3 smoothing: pre-scale image in the paintImageMaskXObject
#1807 Dismiss native browser zoom, and use PDF.JS zoom instead
#1811 Adding explicit masking
#1816 Added missing css vendor prefixes
#1823 PDF.js should use a consistent font for its user interface
#1693 Use a reusable style sheet instead of creating a new tag for each rule.
#1808 UI update from shorlanders comments.
#1837 JBIG2 implementation
#1831 Change to priority/pausible rendering.
#1849 Fix for web worker test in Safari
#1856 Warn instead of fail for CID fonts
#1881 Adds lossless segment types; fixes generic region prediction flag
#1882 Segmentation symbol check for JPX
#1890 Skip properties inherited from array.prototype
#1884 Moz print callback
Comment 1 Brendan Dahl [:bdahl] 2012-07-12 14:05:03 PDT
Created attachment 641588 [details] [diff] [review]
pdf.js 0.3.452

Try run:
https://tbpl.mozilla.org/?tree=Try&rev=cc7c656aa0f2
Comment 2 Brendan Dahl [:bdahl] 2012-07-12 14:10:46 PDT
We've mainly been trying to improve printing over the last six weeks, so there aren't many changes.  For the review the main thing I'd focus are the changes to the PdfStreamConverter(reviewed by Yury already as well) to support downloading the pdf file from a blob instead of re-requesting the file.  See https://github.com/mozilla/pdf.js/pull/1786 for those specific changes.  Most of the other changes are to code that run in content permission code.
Comment 3 Dave Townsend [:mossop] 2012-07-13 14:51:45 PDT
Comment on attachment 641588 [details] [diff] [review]
pdf.js 0.3.452

Review of attachment 641588 [details] [diff] [review]:
-----------------------------------------------------------------

A couple of tweaks but r+ once those are done

::: browser/extensions/pdfjs/components/PdfStreamConverter.js
@@ +133,5 @@
> +    // The data may not be downloaded so we need just retry getting the pdf with
> +    // the original url.
> +    var blobUrl = data.blobUrl || originalUrl;
> +    var originalUri = NetUtil.newURI(originalUrl);
> +    var blobUri = NetUtil.newURI(blobUrl);

You may be parsing the same uri twice here and the near-identical variable names are a little confusing. How about something like this:

var originalUri = NetUtil.newURI(data.originalUrl);
var blobUri = data.blobUrl ? NetUtil.newURI(data.blobUrl) : originalUri;

@@ +143,2 @@
>      var ioService = Services.io;
> +    var channel = ioService.newChannel(originalUrl, null, null);

This channel seems to go unused
Comment 4 Brendan Dahl [:bdahl] 2012-07-13 17:21:57 PDT
Created attachment 642149 [details] [diff] [review]
pdf.js 0.3.452
Comment 5 Brendan Dahl [:bdahl] 2012-07-13 17:23:06 PDT
Updated patch. Check-in needed see previous patch for r+.
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-07-13 20:08:05 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9723f26c8a9
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-07-14 10:02:37 PDT
https://hg.mozilla.org/mozilla-central/rev/f9723f26c8a9

Note You need to log in before you can comment on or make changes to this bug.