Closed Bug 773432 Opened 9 years ago Closed 9 years ago
Image in content
Editable div auto selects it's self when it's in text without spaces around it
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:13.0) Gecko/20100101 Firefox/13.0.1 Build ID: 20120615112143 Steps to reproduce: 1. Click on the editable div 2. The image automatically selects itself If I add a space on either side of the image it's fine but without any spaces it selects itself again. Actual results: Image automatically selects itself Expected results: Nothing
Regression window(m-c) Good: http://hg.mozilla.org/mozilla-central/rev/c7101dec8deb Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111220 Firefox/11.0a1 ID:20111220083550 Bad: http://hg.mozilla.org/mozilla-central/rev/a8506ab2c654 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111220 Firefox/11.0a1 ID:20111220085450 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c7101dec8deb&tochange=a8506ab2c654 Regression window(m-i) Good: http://hg.mozilla.org/integration/mozilla-inbound/rev/feaccb6a4c35 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111219 Firefox/11.0a1 ID:20111219235256 Bad: http://hg.mozilla.org/integration/mozilla-inbound/rev/0aa9c3a5b7e1 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111219 Firefox/11.0a1 ID:20111220011653 Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=feaccb6a4c35&tochange=0aa9c3a5b7e1 Triggered by: Bug 619273
Attachment #641586 - Attachment mime type: text/plain → text/html
The image is part of the spellchecking selection range. I think the fix is to not create an selection overlay at all for images unless they are in the primary selection. https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=4c7d247904d2
Assignee: nobody → matspal
Attachment #641653 - Flags: review+
Target Milestone: --- → mozilla17
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 641653 [details] [diff] [review] fix Review of attachment 641653 [details] [diff] [review]: ----------------------------------------------------------------- A low-risk patch to fix a Web-facing regression. Seems like a good fit for Aurora. The regression doesn't seem serious enough to warrant landing in beta.
Attachment #641653 - Flags: approval-mozilla-aurora?
Comment on attachment 641653 [details] [diff] [review] fix [Triage Comment] Agreed - this isn't a significant enough regression to take on beta. Approving for Aurora 16, however.
Attachment #641653 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.