Image in contentEditable div auto selects it's self when it's in text without spaces around it

RESOLVED FIXED in Firefox 16

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: samjclarke, Assigned: mats)

Tracking

({regression})

13 Branch
mozilla17
x86_64
All
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(firefox13 wontfix, firefox14 wontfix, firefox15- wontfix, firefox16+ fixed)

Details

Attachments

(2 attachments)

Posted file ImageBug.html
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:13.0) Gecko/20100101 Firefox/13.0.1
Build ID: 20120615112143

Steps to reproduce:

1. Click on the editable div
2. The image automatically selects itself

If I add a space on either side of the image it's fine but without any spaces it selects itself again.


Actual results:

Image automatically selects itself


Expected results:

Nothing
OS: Linux → All
Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/c7101dec8deb
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111220 Firefox/11.0a1 ID:20111220083550
Bad:
http://hg.mozilla.org/mozilla-central/rev/a8506ab2c654
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111220 Firefox/11.0a1 ID:20111220085450
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c7101dec8deb&tochange=a8506ab2c654

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/feaccb6a4c35
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111219 Firefox/11.0a1 ID:20111219235256
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/0aa9c3a5b7e1
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111219 Firefox/11.0a1 ID:20111220011653
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=feaccb6a4c35&tochange=0aa9c3a5b7e1

Triggered by: Bug 619273
Blocks: 619273
Status: UNCONFIRMED → NEW
Component: Untriaged → Selection
Ever confirmed: true
Keywords: regression
Product: Firefox → Core
Attachment #641586 - Attachment mime type: text/plain → text/html
Posted patch fixSplinter Review
The image is part of the spellchecking selection range.
I think the fix is to not create an selection overlay at all
for images unless they are in the primary selection.

https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=4c7d247904d2
Assignee: nobody → matspal
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc8981c2ca73
Flags: in-testsuite?
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/bc8981c2ca73
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment on attachment 641653 [details] [diff] [review]
fix

Review of attachment 641653 [details] [diff] [review]:
-----------------------------------------------------------------

A low-risk patch to fix a Web-facing regression. Seems like a good fit for Aurora. The regression doesn't seem serious enough to warrant landing in beta.
Attachment #641653 - Flags: approval-mozilla-aurora?
Comment on attachment 641653 [details] [diff] [review]
fix

[Triage Comment]
Agreed - this isn't a significant enough regression to take on beta. Approving for Aurora 16, however.
Attachment #641653 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.