773450 - Lines don't show up in some Google Maps directions

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[:Margaret Leibovic]

This happens for some sets of directions, and seems to only happen with transit direction (not walking or driving). Here's a testcase: http://goo.gl/maps/YLPH.

Tested on latest nightly (7/12). I can't reproduce on Aurora.

Comment 1

[Logan Rosen [:Logan]]

I've been experiencing this on Mac OS X in the latest nightly builds for a bunch of directions on Google Maps - including driving, walking, etc. Sometimes, it is ameliorated by zooming in. I'm going to try to figure out a regression range, although it's going to be difficult to do an STR, since the lines seem to sporadically work.

Comment 2

[Logan Rosen [:Logan]]

Last good nightly: 2012-07-09
First bad nightly: 2012-07-10

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b6fb3d9bd1b9&tochange=02b26fb307b4

Was able to reproduce consistently with the default zoom level at this link: http://goo.gl/maps/hSI0

Comment 3

[Logan Rosen [:Logan]]

This is occurring for me in the latest nightly build on Windows as well, so I am marking the OS as All.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

The first bad revision is:
changeset:   98666:6e0f0a9228ce
user:        Jonathan Watt <[e-mail]>
date:        Mon Jul 09 02:04:56 2012 +0100
summary:     Bug 769742 - Account for nsSVGOuterSVGFrames' border/padding offset by giving nsSVGOuterSVGFrame an anonymous child to wrap its real children. r=roc.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Thanks for the nightly regression range Logan - made finding a narrower regression range much easier!

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

I'm seeing this as well, though only on Win32 -- couldn't reproduce it on OSX.

Comment 7

[Logan Rosen [:Logan]]

Definitely still able to reproduce on OS X with http://goo.gl/maps/hSI0 in the latest nightly build.

Comment 8

[Jonathan Watt [:jwatt]]

Attachment: patch

The problem occurs when nsDisplayOuterSVG::Paint() passes the nsSVGOuterSVGFrame to nsSVGUtils::PaintFrameWithEffects. PaintFrameWithEffects checks the dirty area against the visual overflow rect of the element, but to do that it takes the transform returned by nsSVGUtils::GetCanvasTM with the children-only component of that transform canceled out. To get that it calls HasChildrenOnlyTransform, which after bug 769742 returns false for nsSVGOuterSVGFrame. Unfortunately bug 769742 didn't also change nsSVGUtils::GetCanvasTM to stop returning the nsSVGSVGElement's transforms for nsSVGOuterSVGFrame.

Comment 9

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f805b2c3b3b4

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f805b2c3b3b4

Comment 11

[Jonathan Watt [:jwatt]]

Comment on attachment 643081 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 769742
User impact if declined: Directions on Goggle Maps are broken
Testing completed (on m-c, etc.): Passed mozilla-inbound and not on mozilla-central
Risk to taking this patch (and alternatives if risky): very low
String or UUID changes made by this patch: none

Comment 12

[Alex Keybl [:akeybl]]

Comment on attachment 643081 [details] [diff] [review]
patch

[Triage Comment]
Google Maps regression in FF16. Approved for Aurora 16.

Comment 13

[Jonathan Watt [:jwatt]]

Pushed https://hg.mozilla.org/releases/mozilla-aurora/rev/b13cc8063a77

Comment 15

[Simona Badau, Desktop QA]

Verified using Firefox 16 beta 3 on Windows 7, Ubuntu 12.04 and Mac OS X 10.7 - that all the lines are properly displayed on Google maps directories (verified on the provided maps from this bug, bug 779432 and some random ones).

Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/20100101 Firefox/16.0
Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20100101 Firefox/16.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:16.0) Gecko/20100101 Firefox/16.0

Comment 16

[Simona Badau, Desktop QA]

Verified on Firefox 17 beta 1 that all the lines are properly displayed on Google maps directory. 

Verified on Windows 7, Ubuntu 12.04 and Mac OS X 10.7:
Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/17.0 Firefox/17.0
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Firefox/17.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Firefox/17.0

Comment 17

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old