Closed
Bug 773462
Opened 12 years ago
Closed 12 years ago
OMTC: Fix calls to ImageContainer::SetCurrentImage in layer transactions
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: nical, Assigned: nical)
Details
Attachments
(1 file)
With bug 598868, ImageContainer got a new and shiny method SetCurrentImageInTransaction better suited to cases where the current image is set on the main thread within a layer transaction. We need to replace the concerned calls to SetCurrentImage by calls to SetCurrentImageInTransaction.
Assignee | ||
Comment 1•12 years ago
|
||
Here is a list of the potentail caller of SetCurrentImage that might be in layer transactions: layout/base/FrameLayerBuilder.cpp 2952: container->SetCurrentImage(image); image/src/RasterImage.cpp 931: mImageContainer->SetCurrentImage(image); dom/plugins/base/nsPluginInstanceOwner.cpp 3703: container->SetCurrentImage(nsnull); dom/plugins/ipc/PluginInstanceParent.cpp 758: container->SetCurrentImage(ioImage); 773: container->SetCurrentImage(pluginImage); I am confident the first two happen at least some times during transactions. roc, you know these parts of the code way better than me, do you know if some of these should be changed for SetCurrentImageInTransaction?
(In reply to Nicolas Silva [:nical] from comment #1) > layout/base/FrameLayerBuilder.cpp > 2952: container->SetCurrentImage(image); > > image/src/RasterImage.cpp > 931: mImageContainer->SetCurrentImage(image); > > dom/plugins/base/nsPluginInstanceOwner.cpp > 3703: container->SetCurrentImage(nsnull); There are actually several SetCurrentImage calls in this file. > roc, you know these parts of the code way better than me, do you know if > some of these should be changed for SetCurrentImageInTransaction? I think they all need to be SetCurrentImageInTransaction.
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #646220 -
Flags: review?(roc)
Attachment #646220 -
Flags: review?(roc) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2fd48f64273e
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•