The default bug view has changed. See this FAQ.

Revert bug 584863 to keep redirect semantics cleaner.

RESOLVED FIXED in mozilla17

Status

()

Core
Networking: HTTP
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jduell, Unassigned)

Tracking

unspecified
mozilla17
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 641628 [details] [diff] [review]
v1

Having an already-cancelled channel fail synchronously when AsyncOpen is called has the bad effect that if the channel is a redirect, it vetoes the redirect (as opposed to continuing with the redirect but cancelling the resulting channel, as calling Cancel after AsyncOpen does).  Cancel should have the same semantics for redirects before/after AsyncOpen.  (see bug 766210 for example).

The only reason I added the sync failure in bug 584863 is it resulted in fewer IPDL messages in e10s (but only for the early cancel case: not worth optimizing).
Attachment #641628 - Flags: review?(honzab.moz)
(Reporter)

Comment 1

5 years ago
Try build at

  https://tbpl.mozilla.org/?tree=Try&rev=59d4d4b8ed5f
(Reporter)

Comment 2

5 years ago
Try looks fine.
Comment on attachment 641628 [details] [diff] [review]
v1

Review of attachment 641628 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab, disavowing from consequences :)
Attachment #641628 - Flags: review?(honzab.moz) → review+
(Reporter)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/42314e12d325
https://hg.mozilla.org/mozilla-central/rev/42314e12d325
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.