Last Comment Bug 773475 - Revert bug 584863 to keep redirect semantics cleaner.
: Revert bug 584863 to keep redirect semantics cleaner.
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Networking: HTTP (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla17
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-12 15:26 PDT by Jason Duell [:jduell] (needinfo? me)
Modified: 2012-08-08 09:44 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (1.08 KB, patch)
2012-07-12 15:26 PDT, Jason Duell [:jduell] (needinfo? me)
honzab.moz: review+
Details | Diff | Review

Description Jason Duell [:jduell] (needinfo? me) 2012-07-12 15:26:10 PDT
Created attachment 641628 [details] [diff] [review]
v1

Having an already-cancelled channel fail synchronously when AsyncOpen is called has the bad effect that if the channel is a redirect, it vetoes the redirect (as opposed to continuing with the redirect but cancelling the resulting channel, as calling Cancel after AsyncOpen does).  Cancel should have the same semantics for redirects before/after AsyncOpen.  (see bug 766210 for example).

The only reason I added the sync failure in bug 584863 is it resulted in fewer IPDL messages in e10s (but only for the early cancel case: not worth optimizing).
Comment 1 Jason Duell [:jduell] (needinfo? me) 2012-07-12 15:55:29 PDT
Try build at

  https://tbpl.mozilla.org/?tree=Try&rev=59d4d4b8ed5f
Comment 2 Jason Duell [:jduell] (needinfo? me) 2012-07-13 10:05:52 PDT
Try looks fine.
Comment 3 Honza Bambas (:mayhemer) 2012-07-16 06:26:13 PDT
Comment on attachment 641628 [details] [diff] [review]
v1

Review of attachment 641628 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab, disavowing from consequences :)
Comment 4 Jason Duell [:jduell] (needinfo? me) 2012-08-07 10:04:22 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/42314e12d325
Comment 5 Ed Morley [:emorley] 2012-08-08 09:44:44 PDT
https://hg.mozilla.org/mozilla-central/rev/42314e12d325

Note You need to log in before you can comment on or make changes to this bug.