Closed
Bug 773500
Opened 13 years ago
Closed 13 years ago
nsStyleAnimation checks for common units of nsCSSValueTriplet are screwy
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: dzbarsky, Assigned: dzbarsky)
Details
Attachments
(2 files, 1 obsolete file)
2.08 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
5.17 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #641646 -
Flags: review?(matt.woodrow)
Assignee | ||
Updated•13 years ago
|
Attachment #641646 -
Flags: review?(matt.woodrow) → review?(dbaron)
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → dzbarsky
Status: NEW → ASSIGNED
Comment on attachment 641646 [details] [diff] [review]
Patch
I don't think ValueTriplet needs a URL check at all, and I suspect that ValuePair does in fact only need the URL check on [0] -- it's needed only for SVG paint servers.
But ValueTriplet should check against null for all three values -- and that check should be fixed in ComputeDistance in addition to AddWeighted.
(I remember pointing this out in another bug somewhere.)
This has come up before; not sure how we still managed not to fix it. It would be great if you could write a revised patch.
Attachment #641646 -
Flags: review?(dbaron) → review-
Assignee | ||
Comment 2•13 years ago
|
||
Yeah, I'm positive I've seen this issue discussed before.
Attachment #641646 -
Attachment is obsolete: true
Attachment #641738 -
Flags: review?(dbaron)
Comment on attachment 641738 [details] [diff] [review]
Patch
r=dbaron
Attachment #641738 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Target Milestone: --- → mozilla16
Summary: nsStyleAnimation checks for common units of nsCSSValuePair/Triplet are screwy → nsStyleAnimation checks for common units of nsCSSValueTriplet are screwy
Comment 5•13 years ago
|
||
I backed this out because of mochitest-4 bustage.
https://hg.mozilla.org/integration/mozilla-inbound/rev/cfa35c4507fd
Example failure log: https://tbpl.mozilla.org/php/getParsedLog.php?id=13502718&tree=Mozilla-Inbound&full=1
Assignee | ||
Comment 6•13 years ago
|
||
If we're going to null-check the zvalue, we should avoid setting it to null.
This change was already part of my transform-origin patch.
Attachment #642061 -
Flags: review?(dbaron)
Comment on attachment 642061 [details] [diff] [review]
Followup
>From: David Zbarsky <dzbarsky@gmail.com>
>
>try: -b do
How about:
Store z-component of transform-origin as null rather than 0 when it is omitted.
r=dbaron with that
This should land before the other patch, I think. Also, when you reland the other patch, don't mention nsCSSValuePair in the summary since the patch doesn't change it.
Attachment #642061 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 8•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/292c6ef7188f
https://hg.mozilla.org/integration/mozilla-inbound/rev/52471266a657
Target Milestone: mozilla16 → mozilla17
Comment 9•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/292c6ef7188f
https://hg.mozilla.org/mozilla-central/rev/52471266a657
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•