|
2.08 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
|
5.17 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
Created attachment 641646 [details] [diff] [review] Patch
|
(Assignee) | |
Updated•5 years ago
|
||
|
|
(Assignee) | |
Updated•5 years ago
|
||
|
||
Comment 1•5 years ago
|
||
Comment on attachment 641646 [details] [diff] [review] Patch I don't think ValueTriplet needs a URL check at all, and I suspect that ValuePair does in fact only need the URL check on [0] -- it's needed only for SVG paint servers. But ValueTriplet should check against null for all three values -- and that check should be fixed in ComputeDistance in addition to AddWeighted. (I remember pointing this out in another bug somewhere.) This has come up before; not sure how we still managed not to fix it. It would be great if you could write a revised patch.
|
|
(Assignee) | |
Comment 2•5 years ago
|
||
Created attachment 641738 [details] [diff] [review] Patch Yeah, I'm positive I've seen this issue discussed before.
|
|
||
Comment 3•5 years ago
|
||
Comment on attachment 641738 [details] [diff] [review] Patch r=dbaron
|
|
(Assignee) | |
Comment 4•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e62e0d2137b6
|
|
||
Updated•5 years ago
|
||
I backed this out because of mochitest-4 bustage. https://hg.mozilla.org/integration/mozilla-inbound/rev/cfa35c4507fd Example failure log: https://tbpl.mozilla.org/php/getParsedLog.php?id=13502718&tree=Mozilla-Inbound&full=1
|
|
(Assignee) | |
Comment 6•5 years ago
|
||
Created attachment 642061 [details] [diff] [review] Followup If we're going to null-check the zvalue, we should avoid setting it to null. This change was already part of my transform-origin patch.
|
|
||
Comment 7•5 years ago
|
||
Comment on attachment 642061 [details] [diff] [review] Followup >From: David Zbarsky <dzbarsky@gmail.com> > >try: -b do How about: Store z-component of transform-origin as null rather than 0 when it is omitted. r=dbaron with that This should land before the other patch, I think. Also, when you reland the other patch, don't mention nsCSSValuePair in the summary since the patch doesn't change it.
|
|
(Assignee) | |
Comment 8•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/292c6ef7188f https://hg.mozilla.org/integration/mozilla-inbound/rev/52471266a657
|
||
Comment 9•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/292c6ef7188f https://hg.mozilla.org/mozilla-central/rev/52471266a657
Description
•