Created attachment 641646 [details] [diff] [review]
Comment on attachment 641646 [details] [diff] [review]
I don't think ValueTriplet needs a URL check at all, and I suspect that ValuePair does in fact only need the URL check on  -- it's needed only for SVG paint servers.
But ValueTriplet should check against null for all three values -- and that check should be fixed in ComputeDistance in addition to AddWeighted.
(I remember pointing this out in another bug somewhere.)
This has come up before; not sure how we still managed not to fix it. It would be great if you could write a revised patch.
Created attachment 641738 [details] [diff] [review]
Yeah, I'm positive I've seen this issue discussed before.
Comment on attachment 641738 [details] [diff] [review]
I backed this out because of mochitest-4 bustage.
Example failure log: https://tbpl.mozilla.org/php/getParsedLog.php?id=13502718&tree=Mozilla-Inbound&full=1
Created attachment 642061 [details] [diff] [review]
If we're going to null-check the zvalue, we should avoid setting it to null.
This change was already part of my transform-origin patch.
Comment on attachment 642061 [details] [diff] [review]
>From: David Zbarsky <email@example.com>
>try: -b do
Store z-component of transform-origin as null rather than 0 when it is omitted.
r=dbaron with that
This should land before the other patch, I think. Also, when you reland the other patch, don't mention nsCSSValuePair in the summary since the patch doesn't change it.