Status

P3
enhancement
7 years ago
3 months ago

People

(Reporter: paul, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
x86
All

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [polish-backlog][difficulty=hard][designer-tools])

Comment hidden (empty)
(Reporter)

Comment 1

6 years ago
Bug triage, filter on PINKISBEAUTIFUL
Priority: -- → P3
See Also: → bug 1030867
Whiteboard: [devedition-40]
As a side note the rule view contains a store that is used to mark changed properties. It shouldn't be too much work to extend this store to contain a change history that could be used for undo / redo.
Whiteboard: [devedition-40] → [devedition-40][difficulty=hard]
Assignee: nobody → gabriel.luong
Whiteboard: [devedition-40][difficulty=hard] → [polish-backlog][difficulty=hard]
After bug 984880, one question is whether undo in the inspector should also
undo changes that were made in the style editor.
(In reply to Tom Tromey :tromey from comment #3)
> After bug 984880, one question is whether undo in the inspector should also
> undo changes that were made in the style editor.

To me it makes sense that undos would only undo things that you've done inside the rule view.  There are all sorts of edge cases though, like if a rule has been removed by style editor / js on the page in the mean time.  Maybe if something like that happens the undo state can be skipped.
Assignee: gabriel.luong → nobody

Comment 5

3 years ago
how do i solve this ?
Comment hidden (spam)
Like bug 785399 this one is rather hard to implement.

- It requires new UI like a context menu entry, a shortcut, or a toolbar icon.
- Handling edge cases like in-page changes (as described in comment 4) is non-trivial.

Therefore, citing Patrick from bug 785399 comment 9 here:
> Having said this, it's a very interesting feature, and if you feel up for
> it, please go ahead. I'm just mentioning that it's hard because I see you're
> new to bugzilla, so I assume you're new to the devtools code base too, and
> this isn't really a good first bug at all (you can find easy and/or mentored
> bugs here: http://firefox-dev.tools/ ).

Sebastian
(In reply to (Unavailable until Jan 4) Brian Grinstead [:bgrins] from comment #4)
> (In reply to Tom Tromey :tromey from comment #3)
> > After bug 984880, one question is whether undo in the inspector should also
> > undo changes that were made in the style editor.
> 
> To me it makes sense that undos would only undo things that you've done
> inside the rule view.  There are all sorts of edge cases though, like if a
> rule has been removed by style editor / js on the page in the mean time. 
> Maybe if something like that happens the undo state can be skipped.

It did seem like the edge cases would be a pain.
If we had unified undo then we could just map "undo" in the rule view to 
whatever code mirror does.  Then the only issue would be making sure that
a rule view edit shows up in code mirror as a single undo record.
Component: Developer Tools: Inspector → Developer Tools: CSS Rules Inspector
Summary: [rule view] implement undo/redo → Implement undo/redo
Severity: normal → enhancement
Whiteboard: [polish-backlog][difficulty=hard] → [polish-backlog][difficulty=hard][designer-tools]
Duplicate of this bug: 1432629

Updated

6 months ago
Product: Firefox → DevTools

Comment 10

3 months ago
Is there any way to bump this up the priority list? This is an essential feature for web developers who design in the browser. 

The edge case mentioned in comment #3 and #4 shouldn't apply, as those changes happen in a different panel. It would not be an expected behavior to undo/redo something from a separate panel.

Currently there is an undo/redo keyboard shortcut in the Inspector panel, but it only works for "Undo delete of a node" and "Redo delete of a node". 

I don't see a context menu entry or a toolbar icon for this undo/redo feature. There should not be a need for toolbar icons or context menu options as this is one of the most basic, universally understood keyboard shortcuts.

I'm new, but it seems this could be accomplished by hooking into the existing keyboard shortcuts and extending the change history to include style changes from the Inspector view.

Is there any way I can help?

Adam
Hey Adam, I got good news for you. Razvan is actively working on this with our Track Changes initiative. It will probably still take a bit of work and time before we will have anything to release publicly.
You need to log in before you can comment on or make changes to this bug.