773522 - Support expiration date or max-age for rendered document content

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Editing, defect, P2)

Description

[Les Orchard [:lorchard]]

Currently, document content rendered through kumascript never expires. It lives forever unless someone edits a page or hits shift-reload.

That's probably fine for most pages, but we might want some pages to never go longer than a certain fixed time without getting rebuilt. (eg. they query bugzilla or otherwise rely on externally changing data feeds)

So, we should support one or both of these fields: expiration date and max-age

At the least, an on-demand rendering should be scheduled if the document rendering has expired or is stale.

Even better, we should have a cronjob that scans through documents and schedules rebuilds of expired or stale content.

Comment 1

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/36016fa1e7628b24e73b6e435cf024595193052a
bug 773522: Fix djcelery tables with a local migration

https://github.com/mozilla/kuma/commit/dd5228c53bb76a1c8ba89c8bc2f2ad06b0426a58
Merge pull request #1623 from lmorchard/773522-wiki-expiration-rebuild

bug 773522: Fix djcelery tables with a local migration

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/b495fc39195359834886275c4e6d53b5e52185a4
bug 773522: Model fields to support concepts of max age and expiration for document rendering

https://github.com/mozilla/kuma/commit/2f84806bbb7cec46b1e69538332882c101323e2c
bug 773522: Model method to render stale documents, either immediately or via delayed queue task

https://github.com/mozilla/kuma/commit/0fb90043bc54fef9b57381c36a6212f931491f51
bug 773522: Account for one-shot render_expires without render_max_age for updates

https://github.com/mozilla/kuma/commit/b9f8f26cb85203a6edb236d03c5a3889faf82494
bug 773522: Update go-tmux

* enable celeryd beat & events

* autoreload celeryd when source change detected

* tweak to not close panes & accept up-arrow when processes get Ctrl-C

https://github.com/mozilla/kuma/commit/d8d3d9767c908f3461bd327f1ec5a31e650f1801
bug 773522: Add rendering expiration celery tasks

* Celery task for rendering stale, with rate limit tweaks

* Add render_expires and render_max_age fields to Document admin

* render_expires is an optional field

* Optionally produce info log messages while rendering stale

* Enable celery queue by default in dev VM

https://github.com/mozilla/kuma/commit/90d0388081db15f23bbed8ae122aba8bb8704f12
bug 773522: Add render_max_age field to Revision and doc editing form

https://github.com/mozilla/kuma/commit/87405da341d343321a2262743ed0fca66d61b279
bug 773522: Quick management command for manually kicking off a round of rendering stale documents

https://github.com/mozilla/kuma/commit/368d9d74473a75844939494986ff4472d55d1ee1
bug 773522: Follow up with previous djcelery migration fix, returns control of migrations to app itself

https://github.com/mozilla/kuma/commit/0e4fb411f583dd428640dd0920b5227b5530d5fc
bug 773522: Remove rate limit from render_stale_documents task

https://github.com/mozilla/kuma/commit/b45f659e2b1e439918e13b68166210b7f74df939
Merge pull request #1687 from lmorchard/773522-time-to-live

bug 773522: Support expiration date or max-age for rendered document content

Comment 3

[Les Orchard [:lorchard]]

This seems to be working on prod, now!

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/464f3ae9c5c3b696ec21a1cf84c91fb344623e64
Revert "bug 773522: Follow up with previous djcelery migration fix, returns control of migrations to app itself"

This reverts commit 368d9d74473a75844939494986ff4472d55d1ee1.