773562 - android.content.ActivityNotFoundException: at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java) on Motorola devices

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P1)

Description

[Scoobidiver (away)]

It's currently #14 top crasher in 14.0b12 where it first appeared and has been hit by 3 users.
The regression range is:
http://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=60598398e29c&tochange=f0f236ff96dd
It's a regression from bug 721760.

android.content.ActivityNotFoundException: Unable to find explicit activity class {com.motorola.blur.setup/com.motorola.blur.settings.AccountsAndServicesPreferenceActivity}; have you declared this activity in your AndroidManifest.xml?
	at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:1508)
	at android.app.Instrumentation.execStartActivity(Instrumentation.java:1384)
	at android.app.Activity.startActivityForResult(Activity.java:3248)
	at android.app.Activity.startActivity(Activity.java:3359)
	at org.mozilla.gecko.sync.setup.SyncAccounts.openSyncSettings(SyncAccounts.java:378)
	at org.mozilla.gecko.sync.setup.activities.SetupSuccessActivity.settingsClickHandler(SetupSuccessActivity.java:81)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at android.view.View$1.onClick(View.java:3041)
	at android.view.View.performClick(View.java:3526)
	at android.view.View$PerformClick.run(View.java:14133)
	at android.os.Handler.handleCallback(Handler.java:605)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4697)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:787)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:554)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=android.content.ActivityNotFoundException%3A+at+android.app.Instrumentation.checkStartActivityResult%28Instrumentation.java%29

Comment 1

[Nick Alexander :nalexander [he/him]]

Relevant code is:

    try {
      // Allow Motorola Blur package to be loaded.
      final int contextFlags = Context.CONTEXT_INCLUDE_CODE | Context.CONTEXT_IGNORE_SECURITY;
      Context foreignContext = context.createPackageContext(MOTO_BLUR_PACKAGE, contextFlags);
      Class<?> motorolaAccounts = foreignContext.getClassLoader().loadClass(MOTO_BLUR_SETTINGS_ACTIVITY);
      Logger.info(LOG_TAG, "Blur package found. Launching Moto activity.");
      intent = new Intent(foreignContext, motorolaAccounts);
    } catch (NameNotFoundException e) {
      Logger.debug(LOG_TAG, "No Blur package. Using default Sync Settings intent.");
      intent = new Intent(Settings.ACTION_SYNC_SETTINGS);
    } catch (ClassNotFoundException e) {
      Logger.warn(LOG_TAG, "Blur package found but no class. Launching Sync Settings normally.", e);
      intent = new Intent(Settings.ACTION_SYNC_SETTINGS);
    }
    intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
    context.startActivity(intent);

Somehow we're finding the class and building the Intent, and then Android is failing.  FFS.  Can we can bandaid?  Wrap startActivity in try catch, fall back to using the Sync intent if we catch an exception?

Comment 2

[Richard Newman [:rnewman]]

(In reply to Nick Alexander :nalexander from comment #1)

> Somehow we're finding the class and building the Intent, and then Android is
> failing.  FFS.  Can we can bandaid?  Wrap startActivity in try catch, fall
> back to using the Sync intent if we catch an exception?

Oh, Android.

Yes, BandAid®. This is hacky workaround code anyway.

Comment 3

[Nick Alexander :nalexander [he/him]]

Test APK at

http://people.mozilla.com/~nalexander/fennec-blur.apk

Test instructions:

First, verify you see the problem:

0. install Nightly.
1. pair Sync with existing Sync account.
2. from Fennec, select Settings > Sync.
3. verify crash of some sort (see above); logs will say for sure.

Second, verify that this works around the problem:

1. install APK (can be on top; should preserve account, etc).
2. Verify that Force Sync works.
3. from Fennec, select Settings > Sync.
4. verify no crash; you should see something like 

D FxSync(16569)               SyncAccounts :: Blur package and class found, but activity not found. Launching Sync Settings normally.

Third, tell us whether you got to the Sync settings, or if you got to Battery & data.  Logs even better!

Comment 4

[Nick Alexander :nalexander [he/him]]

Verified by bnicholson on a RAZR:

14:14 bnicholson: nalexander: your build works for me - it takes me to Accounts & sync
14:15 nalexander: bnicholson: v.g.  Did it crash before?
14:15 bnicholson: yep

Comment 5

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/be16c1ae0133

Comment 6

[Nick Alexander :nalexander [he/him]]

Could we get QA on devices that exhibited Bug 721760, please?

Comment 7

[Aaron Train [:aaronmt]]

(In reply to Nick Alexander :nalexander from comment #6)
> Could we get QA on devices that exhibited Bug 721760, please?

Motorla Droid Pro, tested the above APK and the fix from bug 721760 still holds.

Comment 8

[Alex Keybl [:akeybl]]

We'll be backing out https://bugzilla.mozilla.org/show_bug.cgi?id=721760#c54 on both mozilla-beta and mozilla-release due to this bug.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/be16c1ae0133

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

This doesn't appear to be affecting 15, please correct me if I'm wrong, so I'm untracking and marking unaffected for 15.

Comment 11

[Scoobidiver (away)]

(In reply to Lukas Blakk [:lsblakk] from comment #10)
> This doesn't appear to be affecting 15, please correct me if I'm wrong, so
> I'm untracking and marking unaffected for 15.
15.0a2 is affected.

Comment 12

[Nick Alexander :nalexander [he/him]]

Attachment: patch against m-b

[Approval Request Comment]
Bug caused by (feature/regressing bug #):

Regression from Bug 721760.

User impact if declined:

Continued crashing on some Motorola devices.

Testing completed (on m-c, etc.):

QA has tested this with custom m-b builds.

Risk to taking this patch (and alternatives if risky):

Very low risk -- just catches the relevant exception.

String or UUID changes made by this patch:

None.

Comment 13

[Nick Alexander :nalexander [he/him]]

PS.  This does not need to be landed on m-a.

Comment 14

[Richard Newman [:rnewman]]

Comment on attachment 645052 [details] [diff] [review]
patch against m-b

Review of attachment 645052 [details] [diff] [review]:
-----------------------------------------------------------------

Rubberstamp. But please correct my username in the commit message :)

Comment 15

[Nick Alexander :nalexander [he/him]]

Attachment: patch against m-b

Comment 16

[Nick Alexander :nalexander [he/him]]

Comment on attachment 645057 [details] [diff] [review]
patch against m-b

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:

As above.

Comment 17

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/releases/mozilla-beta/rev/756eff6a7326