773595 - Have nsSVGPatternFrame::GetPatternMatrix use the correct attribute

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

Attachment: patch

Seems to me that nsSVGPatternFrame::GetPatternMatrix should not be looking at patternContentUnits. It should be looking at patternUnits instead.

Here's a patch (passes all our reftests), but I don't have time to write a test right now. If someone wants to come up with one, that'd be great.

Comment 1

[Robert Longson [:longsonr]]

Attachment: reftest

Comment 2

[Jonathan Watt [:jwatt]]

Pushed the patch and a cleaned up version of the test:

https://hg.mozilla.org/integration/mozilla-inbound/rev/b263947c76fc
https://hg.mozilla.org/integration/mozilla-inbound/rev/144a2adc0915

Comment 3

[Jonathan Watt [:jwatt]]

Not 144a2adc0915, sorry, that should be:

https://hg.mozilla.org/integration/mozilla-inbound/rev/b263947c76fc

Comment 4

[Robert Longson [:longsonr]]

The right pushes are:

https://hg.mozilla.org/integration/mozilla-inbound/rev/144a2adc0915
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb1d7f60a3e7

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/144a2adc0915
https://hg.mozilla.org/mozilla-central/rev/fb1d7f60a3e7