Have nsSVGPatternFrame::GetPatternMatrix use the correct attribute

RESOLVED FIXED in mozilla17

Status

()

Core
SVG
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 641811 [details] [diff] [review]
patch

Seems to me that nsSVGPatternFrame::GetPatternMatrix should not be looking at patternContentUnits. It should be looking at patternUnits instead.

Here's a patch (passes all our reftests), but I don't have time to write a test right now. If someone wants to come up with one, that'd be great.
(Assignee)

Updated

5 years ago
Assignee: nobody → jwatt

Comment 1

5 years ago
Created attachment 644645 [details] [diff] [review]
reftest
Attachment #644645 - Flags: review?(jwatt)

Updated

5 years ago
Attachment #641811 - Flags: review+

Updated

5 years ago
Blocks: 719727
(Assignee)

Updated

5 years ago
Attachment #644645 - Flags: review?(jwatt) → review+
(Assignee)

Comment 2

5 years ago
Pushed the patch and a cleaned up version of the test:

https://hg.mozilla.org/integration/mozilla-inbound/rev/b263947c76fc
https://hg.mozilla.org/integration/mozilla-inbound/rev/144a2adc0915
Target Milestone: --- → mozilla17
(Assignee)

Comment 3

5 years ago
Not 144a2adc0915, sorry, that should be:

https://hg.mozilla.org/integration/mozilla-inbound/rev/b263947c76fc

Comment 4

5 years ago
The right pushes are:

https://hg.mozilla.org/integration/mozilla-inbound/rev/144a2adc0915
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb1d7f60a3e7
https://hg.mozilla.org/mozilla-central/rev/144a2adc0915
https://hg.mozilla.org/mozilla-central/rev/fb1d7f60a3e7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.