Closed Bug 773596 Opened 11 years ago Closed 11 years ago

Alarm API - Make Up Missing sendAsyncMessage() for Some Early-Return If Blocks

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla16

People

(Reporter: airpingu, Assigned: airpingu)

References

Details

Attachments

(1 file)

Patch
7.25 KB, patch
vingtetun
: review+
Details | Diff | Splinter Review 
Forgot calling sendAsyncMessage() for some early-return if blocks when adding alarms (my fault!).
Assignee: nobody → clian
Blocks: alarm-api
Attached patch Patch — — Splinter Review 
Hi Vivien,

It's my fault to forget adding sendAsyncMessage() for some early-return if-blocks when adding alarms (really sorry about this...). Make up all the missing calls in this patch. Also, some code clean-ups: 

1. Refactor all the ppmm.sendAsyncMessage() calls with a private _sendAsyncMessage(), which makes codes cleaner and shorter.
2. Replace requestID with requestId, which looks more comfortable.

Gene
Attachment #641823 - Flags: review?(21)
Keywords: checkin-needed
Whiteboard: Try-server result: https://tbpl.mozilla.org/?tree=Try&rev=e86a366e31a3
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad04b9931208
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: Try-server result: https://tbpl.mozilla.org/?tree=Try&rev=e86a366e31a3
https://hg.mozilla.org/mozilla-central/rev/ad04b9931208
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.