Last Comment Bug 773596 - Alarm API - Make Up Missing sendAsyncMessage() for Some Early-Return If Blocks
: Alarm API - Make Up Missing sendAsyncMessage() for Some Early-Return If Blocks
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Gene Lian [:gene] (I already quit Mozilla)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: alarm-api
  Show dependency treegraph
 
Reported: 2012-07-13 04:30 PDT by Gene Lian [:gene] (I already quit Mozilla)
Modified: 2012-07-14 10:02 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (7.25 KB, patch)
2012-07-13 05:02 PDT, Gene Lian [:gene] (I already quit Mozilla)
21: review+
Details | Diff | Splinter Review

Description Gene Lian [:gene] (I already quit Mozilla) 2012-07-13 04:30:36 PDT
Forgot calling sendAsyncMessage() for some early-return if blocks when adding alarms (my fault!).
Comment 1 Gene Lian [:gene] (I already quit Mozilla) 2012-07-13 05:02:35 PDT
Created attachment 641823 [details] [diff] [review]
Patch

Hi Vivien,

It's my fault to forget adding sendAsyncMessage() for some early-return if-blocks when adding alarms (really sorry about this...). Make up all the missing calls in this patch. Also, some code clean-ups: 

1. Refactor all the ppmm.sendAsyncMessage() calls with a private _sendAsyncMessage(), which makes codes cleaner and shorter.
2. Replace requestID with requestId, which looks more comfortable.

Gene
Comment 2 Ryan VanderMeulen [:RyanVM] 2012-07-13 21:02:52 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad04b9931208
Comment 3 Ryan VanderMeulen [:RyanVM] 2012-07-14 10:02:32 PDT
https://hg.mozilla.org/mozilla-central/rev/ad04b9931208

Note You need to log in before you can comment on or make changes to this bug.