Closed
Bug 773596
Opened 13 years ago
Closed 13 years ago
Alarm API - Make Up Missing sendAsyncMessage() for Some Early-Return If Blocks
Categories
(Core :: DOM: Device Interfaces, defect)
Core
DOM: Device Interfaces
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: airpingu, Assigned: airpingu)
References
Details
Attachments
(1 file)
|
7.25 KB,
patch
|
vingtetun
:
review+
|
Details | Diff | Splinter Review |
Forgot calling sendAsyncMessage() for some early-return if blocks when adding alarms (my fault!).
|
Assignee | |
Comment 1•13 years ago
|
||
Hi Vivien,
It's my fault to forget adding sendAsyncMessage() for some early-return if-blocks when adding alarms (really sorry about this...). Make up all the missing calls in this patch. Also, some code clean-ups:
1. Refactor all the ppmm.sendAsyncMessage() calls with a private _sendAsyncMessage(), which makes codes cleaner and shorter.
2. Replace requestID with requestId, which looks more comfortable.
Gene
Attachment #641823 -
Flags: review?(21)
Attachment #641823 -
Flags: review?(21) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: Try-server result: https://tbpl.mozilla.org/?tree=Try&rev=e86a366e31a3
|
||
Comment 2•13 years ago
|
||
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: Try-server result: https://tbpl.mozilla.org/?tree=Try&rev=e86a366e31a3
|
|
||
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in
before you can comment on or make changes to this bug.
Description
•