The default bug view has changed. See this FAQ.

Alarm API - Make Up Missing sendAsyncMessage() for Some Early-Return If Blocks

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Gene Lian (I already quit Mozilla), Assigned: Gene Lian (I already quit Mozilla))

Tracking

Trunk
mozilla16
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Forgot calling sendAsyncMessage() for some early-return if blocks when adding alarms (my fault!).
(Assignee)

Updated

5 years ago
Assignee: nobody → clian
Blocks: 749551
(Assignee)

Comment 1

5 years ago
Created attachment 641823 [details] [diff] [review]
Patch

Hi Vivien,

It's my fault to forget adding sendAsyncMessage() for some early-return if-blocks when adding alarms (really sorry about this...). Make up all the missing calls in this patch. Also, some code clean-ups: 

1. Refactor all the ppmm.sendAsyncMessage() calls with a private _sendAsyncMessage(), which makes codes cleaner and shorter.
2. Replace requestID with requestId, which looks more comfortable.

Gene
Attachment #641823 - Flags: review?(21)
Attachment #641823 - Flags: review?(21) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Whiteboard: Try-server result: https://tbpl.mozilla.org/?tree=Try&rev=e86a366e31a3
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad04b9931208
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: Try-server result: https://tbpl.mozilla.org/?tree=Try&rev=e86a366e31a3
https://hg.mozilla.org/mozilla-central/rev/ad04b9931208
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.