773626 - Hash functions for MaskLayerImageCache::PixelRoundedRect and MaskLayerImageCache::MaskLayerImageKey suck

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

PixelRoundedRect::Hash() only looks at mRect, and MaskLayerImageKey::Hash() always returns 0.

Comment 1

[Nick Cameron [:nrc]]

Attachment: fix

sorry, silly mistake

Comment 2

[Mozilla RelEng Bot]

Try run for 60ce617d687d is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=60ce617d687d
Results (out of 293 total builds):
    exception: 7
    success: 202
    warnings: 14
    failure: 70
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-60ce617d687d

Comment 3

[Mozilla RelEng Bot]

Try run for 40ccbe6b037f is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=40ccbe6b037f
Results (out of 300 total builds):
    exception: 1
    success: 273
    warnings: 20
    failure: 6
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-40ccbe6b037f

Comment 4

[Nick Cameron [:nrc]]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=b85bf85ebc06

Comment 5

[Ed Morley [:emorley]]

Didn't make it to mozilla-central before the uplift (merge was blocked on bug 774259). Adjusting milestone accordingly.

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b85bf85ebc06