Last Comment Bug 773626 - Hash functions for MaskLayerImageCache::PixelRoundedRect and MaskLayerImageCache::MaskLayerImageKey suck
: Hash functions for MaskLayerImageCache::PixelRoundedRect and MaskLayerImageCa...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics: Layers (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Nick Cameron [:nrc]
:
: Milan Sreckovic [:milan]
Mentors:
Depends on:
Blocks: buildwarning 757347
  Show dependency treegraph
 
Reported: 2012-07-13 06:46 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-07-17 02:14 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (1.35 KB, patch)
2012-07-13 15:02 PDT, Nick Cameron [:nrc]
roc: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-07-13 06:46:48 PDT
PixelRoundedRect::Hash() only looks at mRect, and MaskLayerImageKey::Hash() always returns 0.
Comment 1 Nick Cameron [:nrc] 2012-07-13 15:02:29 PDT
Created attachment 642075 [details] [diff] [review]
fix

sorry, silly mistake
Comment 2 Mozilla RelEng Bot 2012-07-14 08:00:25 PDT
Try run for 60ce617d687d is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=60ce617d687d
Results (out of 293 total builds):
    exception: 7
    success: 202
    warnings: 14
    failure: 70
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ncameron@mozilla.com-60ce617d687d
Comment 3 Mozilla RelEng Bot 2012-07-14 21:00:24 PDT
Try run for 40ccbe6b037f is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=40ccbe6b037f
Results (out of 300 total builds):
    exception: 1
    success: 273
    warnings: 20
    failure: 6
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ncameron@mozilla.com-40ccbe6b037f
Comment 5 Ed Morley [:emorley] 2012-07-16 11:15:16 PDT
Didn't make it to mozilla-central before the uplift (merge was blocked on bug 774259). Adjusting milestone accordingly.
Comment 6 Ed Morley [:emorley] 2012-07-17 02:14:33 PDT
https://hg.mozilla.org/mozilla-central/rev/b85bf85ebc06

Note You need to log in before you can comment on or make changes to this bug.