773658 - Kuma: Template editor - Add warning before discarding edits

Status: VERIFIED FIXED

(developer.mozilla.org Graveyard :: Wiki pages, defect, P1)

Description

[Eric Shepherd [:sheppy]]

Sometimes you hit the discard button just to avoid adding an additional save on your template because you don't think you made any changes. Sometimes, it turns out you're wrong and you did. Please add a warning confirmation if there were in fact changes.

Comment 1

[John Karahalis [:openjck]]

Thanks for reporting this, Sheppy.

I would avoid the temptation to use a simple confirmation box -- users learn to ignore them, and instead habituate to clicking the "proceed as usual" button. Have you ever clicked "Yes" in a confirmation box only to realize you have no idea what you agreed to? Same principle.

Instead, I would prefer a GMail-like undo interface: http://docs.moodle.org/dev/images_dev/6/6c/gmail-undo-example.png

Comment 2

[Eric Shepherd [:sheppy]]

That would work fine too, although I suspect it's harder to implement. If we could get a confirmation dialog added for the short term, that would at least be an improvement.

Also, this needs to be done for discarding anything, not just templates; renaming this bug accordingly.

Comment 3

[Eric Shepherd [:sheppy]]

Also, now that I realize this isn't just about templates, but all edits, this needs to be a bit higher priority; adjusting.

Comment 4

[David Walsh :davidwalsh]

I've been working on this...

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/e271ce7b647546fbd5b99cb4030bf09d322cbe75
fix bug 773658 - Show message before leaving page

https://github.com/mozilla/kuma/commit/1225939903033ee2f7d5e8007a58051dff72cdab
Merge pull request #504 from darkwing/kuma-templates-773658

fix bug 773658 - Show message before leaving page

Comment 6

[raymond [:retornam] (inactive)]

verified fixed https://developer.allizom.org/en-US/docs/onetwo.  Sorry about the false alarm David. I just  had to clear my cache