Last Comment Bug 773665 - crash in CrashReporter::GetPendingDir
: crash in CrashReporter::GetPendingDir
: crash, regression, topcrash
Product: Toolkit
Classification: Components
Component: Breakpad Integration (show other bugs)
: 16 Branch
: x86 Windows 7
-- critical (vote)
: mozilla16
Assigned To: Benjamin Smedberg [:bsmedberg]
: Ted Mielczarek [:ted.mielczarek]
Depends on:
Blocks: 771251
  Show dependency treegraph
Reported: 2012-07-13 08:48 PDT by Scoobidiver (away)
Modified: 2012-08-10 05:25 PDT (History)
6 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Null-check, rev. 1 (948 bytes, patch)
2012-07-13 10:01 PDT, Benjamin Smedberg [:bsmedberg]
ted: review+
lukasblakk+bugs: approval‑mozilla‑beta+
Details | Diff | Splinter Review

Description User image Scoobidiver (away) 2012-07-13 08:48:14 PDT
It's currently #1 top crasher in today's build where it appeared for the first time. The regression window is:
It's probably a regression from bug 771251 as there are no Flash crashes in this build.

Signature 	CrashReporter::GetPendingDir More Reports Search
UUID	bfd71428-b350-4e3e-b99e-7f7d72120713
Date Processed	2012-07-13 15:35:03
Uptime	66
Last Crash	more than 3 months before submission
Install Age	15.4 minutes since version was first installed.
Install Time	2012-07-13 15:18:45
Product	Firefox
Version	16.0a1
Build ID	20120713030548
Release Channel	nightly
OS	Windows NT
OS Version	6.1.7601 Service Pack 1
Build Architecture	x86
Build Architecture Info	GenuineIntel family 6 model 37 stepping 2
Crash Address	0x0
App Notes 	
AdapterVendorID: 0x8086, AdapterDeviceID: 0x0046, AdapterSubsysID: 040a1028, AdapterDriverVersion:
D2D? D2D+ DWrite? DWrite+ D3D10 Layers? D3D10 Layers+ 
EMCheckCompatibility	True
Adapter Vendor ID	0x8086
Adapter Device ID	0x0046
Total Virtual Memory	4294836224
Available Virtual Memory	3775848448
System Memory Use Percentage	28
Available Page File	13537292288
Available Physical Memory	5987373056

Frame 	Module 	Signature 	Source
0 	xul.dll 	CrashReporter::GetPendingDir 	toolkit/crashreporter/nsExceptionHandler.cpp:1711
1 	xul.dll 	CrashReporter::MoveToPending 	toolkit/crashreporter/nsExceptionHandler.cpp:1914
2 	xul.dll 	CrashReporter::OnChildProcessDumpRequested 	toolkit/crashreporter/nsExceptionHandler.cpp:1970
3 	xul.dll 	google_breakpad::CrashGenerationServer::HandleDumpRequest 	toolkit/crashreporter/google-breakpad/src/client/windows/crash_generation/
4 	xul.dll 	google_breakpad::CrashGenerationServer::OnDumpRequest 	toolkit/crashreporter/google-breakpad/src/client/windows/crash_generation/
5 	ntdll.dll 	RtlpTpWaitCallback 	
6 	ntdll.dll 	TppWaitpExecuteCallback 	
7 	ntdll.dll 	TppCallbackCheckThreadBeforeCallback 	
8 	kernel32.dll 	BaseThreadInitThunk 	
9 	ntdll.dll 	__RtlUserThreadStart 	
10 	ntdll.dll 	_RtlUserThreadStart

More reports at:
Comment 1 User image Benjamin Smedberg [:bsmedberg] 2012-07-13 10:01:13 PDT
Created attachment 641941 [details] [diff] [review]
Null-check, rev. 1
Comment 2 User image Ted Mielczarek [:ted.mielczarek] 2012-07-13 10:21:04 PDT
Comment on attachment 641941 [details] [diff] [review]
Null-check, rev. 1

Review of attachment 641941 [details] [diff] [review]:

Kind of a bummer, I guess we'll just orphan these files? We should investigate why this winds up as a topcrash, presumably there must be some shutdown plugin topcrash.
Comment 3 User image Benjamin Smedberg [:bsmedberg] 2012-07-13 20:25:52 PDT
Comment 4 User image Benjamin Smedberg [:bsmedberg] 2012-07-13 20:26:30 PDT
The outcome of IRC discussions is that this is a common shutdown crash that bc is seeing, and that this patch won't make it any worse.
Comment 5 User image Benjamin Smedberg [:bsmedberg] 2012-07-13 20:28:43 PDT
Comment on attachment 641941 [details] [diff] [review]
Null-check, rev. 1

Bug caused by (feature/regressing bug #): bug 771251
User impact if declined: crashes (assuming we take bug 771251, which we really need for correct Flash crash reporting
Testing completed (on m-c, etc.): landed on m-c, should be verified by crash-stats tomorrow
Risk to taking this patch (and alternatives if risky): no risk (all the risk is in bug 771251)
Comment 6 User image Lukas Blakk [:lsblakk] use ?needinfo 2012-07-16 15:22:50 PDT
Tracking for 15 which I think is what you're looking for here now, post merge.
Comment 7 User image Lukas Blakk [:lsblakk] use ?needinfo 2012-07-16 15:23:29 PDT
Comment on attachment 641941 [details] [diff] [review]
Null-check, rev. 1

[Triage Comment]
Please land to beta immediately so we have this in our first beta build.
Comment 8 User image Benjamin Smedberg [:bsmedberg] 2012-07-18 06:33:04 PDT

Note You need to log in before you can comment on or make changes to this bug.