773724 - XPCOM preloads delay load modules on Windows

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Jim Mathies [:jimm]]

Really weird behavior now that we include vccorlib110 in our distribution. This doesn't get in the way of running the app, but it does generate an error that you can dismiss. There are some hackish ways around this but I'd like to try and understand why windows is temporarily loading a delay load module when it shouldn't.

'firefox.exe' (Win32): Loaded 'C:\Users\jim\Desktop\firefox\msvcp110.dll'.
'firefox.exe' (Win32): Loaded 'C:\Users\jim\Desktop\firefox\gkmedias.dll'.
'firefox.exe' (Win32): Loaded 'C:\Windows\SysWOW64\msdmo.dll'. Symbols loaded.
'firefox.exe' (Win32): Loaded 'C:\Windows\SysWOW64\msimg32.dll'. Symbols loaded.
'firefox.exe' (Win32): Loaded 'C:\Users\jim\Desktop\firefox\vccorlib110.dll'.
'firefox.exe' (Win32): Unloaded 'C:\Users\jim\Desktop\firefox\vccorlib110.dll'
'firefox.exe' (Win32): Loaded 'C:\Users\jim\Desktop\firefox\xul.dll'.
'firefox.exe' (Win32): Loaded 'C:\Windows\SysWOW64\version.dll'. Symbols loaded.
'firefox.exe' (Win32): Loaded 'C:\Windows\SysWOW64\IPHLPAPI.DLL'. Symbols loaded.
'firefox.exe' (Win32): Loaded 'C:\Windows\SysWOW64\winnsi.dll'. Symbols loaded.
'firefox.exe' (Win32): Loaded 'C:\Windows\SysWOW64\uxtheme.dll'. Symbols loaded.
'firefox.exe' (Win32): Loaded 'C:\Windows\SysWOW64\setupapi.dll'. Symbols loaded.
'firefox.exe' (Win32): Loaded 'C:\Windows\SysWOW64\cfgmgr32.dll'. Symbols loaded.
'firefox.exe' (Win32): Loaded 'C:\Windows\SysWOW64\devobj.dll'. Symbols loaded.
'firefox.exe' (Win32): Loaded 'C:\Users\jim\Desktop\firefox\dummyvccorlib.dll'.

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch

Turns out this isn't Windows, it's our preloading logic in xpcomglue which loads a list of dependency libs on startup, including vccorlib110.dll.

Comment 2

[Jim Mathies [:jimm]]

Attachment: patch

w/needed make logic

Comment 3

[Jim Mathies [:jimm]]

https://hg.mozilla.org/projects/elm/rev/bf5acae0c984

testing this on elm first to be sure it's working as expected.

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 642712 [details] [diff] [review]
patch

Slight enhancement to dependentlibs.py which allows callers to filter certain libs out of the resulting list. We use this on Win8 to avoid loading a delay load module which will fail to load on os < Win8.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Skip delayload libraries in dependentlibs.py

Jim, can you test this?

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 642712 [details] [diff] [review]
patch

Better not to rely on manual work when the required data is already there in the dlls.

Comment 7

[Jim Mathies [:jimm]]

Comment on attachment 642712 [details] [diff] [review]
patch

Yes, that seems to do the trick.

Comment 8

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41f7e82c794c

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/41f7e82c794c