Closed
Bug 773730
Opened 12 years ago
Closed 12 years ago
Set all styles for text selection handles in one call
Categories
(Firefox for Android Graveyard :: Text Selection, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 16
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(1 file)
|
7.29 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
We want to minimize our element.style calls. Also, we don't need to always be adjusting the height/width of the handles if the zoom didn't change. Is using cssText like this the right way to do this? I'm appending the new values because I don't want to pave over all the other styles on the handles.
Attachment #641965 -
Flags: review?(mark.finkle)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 641965 [details] [diff] [review] patch OK, let's try this. We also need to look at using nsIDOMWindowUtil.getScrollPos instead of this._view.scrollX / Y We also should make a local var for places where we request this._view.scrollX / Y more than once in a function.
Attachment #641965 -
Flags: review?(mark.finkle) → review+
|
Assignee | |
Updated•12 years ago
|
|
|
Assignee | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/90ef3533fa48
Target Milestone: --- → Firefox 16
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/90ef3533fa48
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•