Closed
Bug 773731
Opened 12 years ago
Closed 12 years ago
SpiderMonkey: UseNewType pattern matching broken.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: djvj, Assigned: djvj)
References
Details
Attachments
(1 file)
|
1.33 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
Ran into this while working on Bug 770309. A recent change to jsinterp.cpp's handling of JSOP_NEW breaks UseNewType's pattern matching. It modified the current context to refer to the callee before calling UseNewType, when UseNewType operates on the caller. Fix should be quick, some small re-ordering of code.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #642051 -
Flags: review?(bhackett1024)
|
||
Updated•12 years ago
|
Attachment #642051 -
Flags: review?(bhackett1024) → review+
|
||
Comment 2•12 years ago
|
||
This landed on inbound as: https://hg.mozilla.org/integration/mozilla-inbound/rev/8837ebfb3045 However the bug number was incorrect. Please can you backout and reland with the correct # so as to make hg blame clearer. Thanks :-)
Target Milestone: --- → mozilla17
|
|
Assignee | |
Comment 3•12 years ago
|
||
Thanks for the heads up :) Reverted, fixed, and pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/3b2bad6c343b
|
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3b2bad6c343b
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•