Closed Bug 773731 Opened 10 years ago Closed 10 years ago

SpiderMonkey: UseNewType pattern matching broken.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: djvj, Assigned: djvj)

References

Details

Attachments

(1 file)

Ran into this while working on Bug 770309.

A recent change to jsinterp.cpp's handling of JSOP_NEW breaks UseNewType's pattern matching.  It modified the current context to refer to the callee before calling UseNewType, when UseNewType operates on the caller.

Fix should be quick, some small re-ordering of code.
Assignee: general → kvijayan
Blocks: 770309
Attached patch Patch.Splinter Review
Attachment #642051 - Flags: review?(bhackett1024)
Attachment #642051 - Flags: review?(bhackett1024) → review+
This landed on inbound as:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8837ebfb3045

However the bug number was incorrect.

Please can you backout and reland with the correct # so as to make hg blame clearer.

Thanks :-)
Target Milestone: --- → mozilla17
Thanks for the heads up :)  Reverted, fixed, and pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b2bad6c343b
https://hg.mozilla.org/mozilla-central/rev/3b2bad6c343b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Depends on: 793491
Depends on: 816439
No longer depends on: 816439
You need to log in before you can comment on or make changes to this bug.