The default bug view has changed. See this FAQ.

SpiderMonkey: UseNewType pattern matching broken.

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: djvj, Assigned: djvj)

Tracking

unspecified
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Ran into this while working on Bug 770309.

A recent change to jsinterp.cpp's handling of JSOP_NEW breaks UseNewType's pattern matching.  It modified the current context to refer to the callee before calling UseNewType, when UseNewType operates on the caller.

Fix should be quick, some small re-ordering of code.
(Assignee)

Updated

5 years ago
Assignee: general → kvijayan
Blocks: 770309
(Assignee)

Comment 1

5 years ago
Created attachment 642051 [details] [diff] [review]
Patch.
Attachment #642051 - Flags: review?(bhackett1024)
Attachment #642051 - Flags: review?(bhackett1024) → review+
This landed on inbound as:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8837ebfb3045

However the bug number was incorrect.

Please can you backout and reland with the correct # so as to make hg blame clearer.

Thanks :-)
Target Milestone: --- → mozilla17
(Assignee)

Comment 3

5 years ago
Thanks for the heads up :)  Reverted, fixed, and pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b2bad6c343b
https://hg.mozilla.org/mozilla-central/rev/3b2bad6c343b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Depends on: 793491
Depends on: 816439
No longer depends on: 816439
You need to log in before you can comment on or make changes to this bug.