Do not use tablet layout on devices with screen size "large"

VERIFIED FIXED in Firefox 15

Status

()

Firefox for Android
Theme and Visual Design
VERIFIED FIXED
5 years ago
11 months ago

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Tracking

({regression})

16 Branch
Firefox 16
All
Android
regression
Points:
---

Firefox Tracking Flags

(firefox15+ fixed, firefox16 verified)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 641970 [details]
Nightly on 7" Galaxy Tab

In bug 770079 we switched to using the native tablet layout on all devices with screen size "large" or higher.  This includes 7" tablets, and some 5" devices like some versions of the Galaxy Note.  But our tablet UI, at least as currently implemented does not really work well on these mid-size devices, especially in portrait mode.  (See the attached screenshot.)

I don't think the tablet UI is ready for these devices, and at least for Firefox 15 and 16 it would be better to ship the phone UI for "large" screen sizes.  In a later release we can make the UI adapt more specifically to these devices.

For comparison, the XUL Fennec tablet UI was used only on "xlarge" devices (with an exception for "large" Honeycomb tablets, because the XUL phone UI had some problems on those devices).
(Assignee)

Updated

5 years ago
Attachment #641970 - Attachment is patch: false
Attachment #641970 - Attachment mime type: text/plain → image/png
(Assignee)

Comment 1

5 years ago
We can make this change in Native Fennec without re-introducing the complications and duplicate code that bug 770079 removed.

The easiest option is to just rename all of our *-large directories to *-xlarge.  Then we will use the tablet layout only on "xlarge" screens (960x720 "dips" or larger) -- this includes 9" and 10" tablets, and exclude most smaller devices.
(Assignee)

Comment 2

5 years ago
Created attachment 641986 [details] [diff] [review]
patch

On IRC, madhava wrote:

> mbrubeck: yeah - based on that definition of large, I wouldn't do tablet UI there
> I know that ibarlow had a different layout in mind for 7" that was more an adapted version of the phone UI
> i.e. tabs at the top

This patch just renames every *-large* path to *-xlarge*, and adjusts the isTablet methods.  (It also takes one step toward combining the two isTablet methods into one.)

For anyone following along:  I know the phone layout is not perfect for 7" tablets; we just think it's better than the tablet layout *for now*.  In future releases we will refine the UI for small tablets.
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attachment #641986 - Flags: review?(mark.finkle)
Comment on attachment 641986 [details] [diff] [review]
patch

>diff --git a/mobile/android/base/GeckoAppShell.java b/mobile/android/base/GeckoAppShell.java

>     public static boolean isTablet() {

>+        return GeckoApp.mAppContext.isTablet();

Given the activity issues and static woes, maybe GeckoAppShell should hold the real impl and GeckoApp can delegate to it.

>diff --git a/mobile/android/base/Makefile.in b/mobile/android/base/Makefile.in

> RES_LAYOUT_LARGE = \

> RES_VALUES_LARGE = \

> RES_DRAWABLE_LARGE_MDPI = \

> RES_DRAWABLE_LARGE_HDPI = \

> RES_DRAWABLE_LARGE_XHDPI = \

To minimize confusion, can we rename these variable too? LARGE -> XLARGE

> RESOURCES=$(RES_LAYOUT) $(RES_LAYOUT_LAND_V14) $(RES_LAYOUT_LARGE) $(RES_VALUES) $(RES_VALUES_V11) $(RES_VALUES_LARGE) $(RES_VALUES_LAND_V14) $(RES_VALUES_LARGE_V14) $(RES_XML) $(RES_ANIM) $(RES_DRAWABLE_NODPI) $(RES_DRAWABLE_BASE) $(RES_DRAWABLE_LDPI) $(RES_DRAWABLE_HDPI) $(RES_DRAWABLE_XHDPI) $(RES_DRAWABLE_MDPI_V11) $(RES_DRAWABLE_HDPI_V11) $(RES_DRAWABLE_XHDPI_V11) $(RES_DRAWABLE_LAND_V14) $(RES_DRAWABLE_LAND_MDPI_V14) $(RES_DRAWABLE_LAND_HDPI_V14) $(RES_DRAWABLE_LAND_XHDPI_V14) $(RES_DRAWABLE_LARGE_MDPI) $(RES_DRAWABLE_LARGE_HDPI) $(RES_DRAWABLE_LARGE_XHDPI) $(RES_COLOR) $(RES_MENU) $(RES_RAW)

And here
Attachment #641986 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9368a54926a5
Keywords: uiwanted
Target Milestone: --- → Firefox 16
(Assignee)

Comment 5

5 years ago
Comment on attachment 641986 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug  	770079

User impact if declined: Some mid-sized devices switch to the large-screen tablet layout.

Testing completed (on m-c, etc.): Landed on inbound 7/13.

Risk to taking this patch (and alternatives if risky): This is mobile-only and low-risk.  All it does is change "large" to "xlarge" in all of our resource directories.  (So it touches a large number number of files, but the only change to each file is a trivial mechanical change to the filename.)

String or UUID changes made by this patch: None.
Attachment #641986 - Flags: approval-mozilla-aurora?

Updated

5 years ago
tracking-firefox15: ? → +
https://hg.mozilla.org/mozilla-central/rev/9368a54926a5
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
status-firefox15: --- → affected
Attachment #641986 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
We need this mobile-only style change to keep some phablets from getting the tablet UI.
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/102d52e466e6
status-firefox15: affected → fixed
Only able to verify on a Galaxy Tab 2 7" here (1024x600) and I the phone UI.

Verified on Nightly (07/14)
Status: RESOLVED → VERIFIED
status-firefox16: --- → verified
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.