773741 - Cannot resize elements in Fennec that have the CSS resize property

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Mardeg]

Attachment: Testcase

Tested on today's Firefox mobile nightly trunk on Galaxy Nexus, Android 4.1.1 Jellybean.
The grippy appears but touching/dragging it does nothing in either the attached testcase or the linked example.

Comment 1

[Mardeg]

Confirmed in IRC on 2.3.7 Gingerbread and 4.0.4 Ice-Cream Sandwich.

Comment 2

[microrffr]

good news. https://bugzilla.mozilla.org/show_bug.cgi?id=775151

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Patch v1

This works well, but its tough to tap on our current resizers. Maybe we need to increase their tappable size, or talk to ux about redesigning them.

Also, I'm betting you ask for tests.....

Comment 5

[Neil Deakin]

Comment on attachment 643612 [details] [diff] [review]
Patch v1

>+
>+bool
>+nsBoxFrame::GetEventPoint(nsGUIEvent* aEvent, nsPoint &aPoint) {
>+  nsIntPoint refPoint;
>+  bool res = GetEventPoint(aEvent, refPoint);
>+  aPoint = nsLayoutUtils::GetEventCoordinatesRelativeTo(aEvent, refPoint, this);
>+  return res;
>+}
>+
>+bool
>+nsBoxFrame::GetEventPoint(nsGUIEvent* aEvent, nsIntPoint &aPoint) {
>+  nsresult rv;
>+  if (aEvent->eventStructType == NS_TOUCH_EVENT) {
>+    rv = GetTouchPoint(static_cast<nsTouchEvent*>(aEvent), aPoint);
>+    if (NS_FAILED(rv))
>+       return false;

GetTouchPoint returns bool not nsresult.

You could also probably combine GetEventPoint and GetTouchPoint into one method instead. They could also be protected methods or even static.

Comment 6

[Wesley Johnston (:wesj)]

Attachment: Patch v2

Update nsBoxFrame methods.

Comment 7

[Neil Deakin]

The new test file is missing from the patch.

Comment 8

[Wesley Johnston (:wesj)]

Attachment: tests

This updates the already existing tests to use touch events as well. It also adds some helpers to EventUtils for (single) touch events. Pushed to try:

https://tbpl.mozilla.org/?tree=Try&rev=25176e73ff1a

Comment 9

[Wesley Johnston (:wesj)]

Whoops. I didn't realize the test_resizer_touchevents.xul bit was in there. Will pull it and push to try again.

Comment 10

[Wesley Johnston (:wesj)]

Thanks neil. Second try push is still running as well, but looks ok so far:
https://tbpl.mozilla.org/?tree=Try&rev=8e4ec4f3137c

Comment 11

[Neil Deakin]

Comment on attachment 646347 [details] [diff] [review]
tests

> function doTheTest() {
>+  textarea.style.resize = resizeTypes[currentResize];
>+  runTest(pointerTypes[currentPointer]);
>+}

The test used to perform an iteration using the default value for 'resize'. (The comment still describes this behaviour and is now inaccurate). It would be nice to maintain this. You could do this by not setting 'resize' for the first pass, add an extra value to resizeTypes, and skip this for touch events.

Comment 12

[Wesley Johnston (:wesj)]

Fixed test. Inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/377f1998ca05
https://hg.mozilla.org/integration/mozilla-inbound/rev/853e5839a8af

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/853e5839a8af
https://hg.mozilla.org/mozilla-central/rev/377f1998ca05