773764 - Changes to Air Mozilla Event (Brownbag) Request Form

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[Richard A Milewski[:richard]]

1. Change the Start Time drop-downs to accommodate a 24 hour clock (drop the AM/PM field) and make the time zone default to UTC+0.   Change the label to "Start Time (24 hr clock)".

2. Change the "Location:" label to "Originating Location:"

3. Add a line after "Originating Location" that says:  "Show on large screens in these Mozilla Spaces Commons:"  and add checkboxes for MTV, SFO, TOR, LON

4. Replace the "Intended Audience" dropdown with a radio button pair (no default) that says "This event may be viewed by the public: Yes  No".   The form MUST refuse to post unless one of the radio buttons has been pushed.

5. On the next line add a text box labeled: "Steering Committee Contact Email:"   Below that add a line of text that says (This is usually the person in your reporting chain that reports to the CEO).

Remove the Dial In?, and Archive This? checkboxes.

Change the text after Description: to: "Please describe the event the way you would in a program guide listing".

Add an additional text area labeled "Special Requirements".

On submission, the form should attach a text file to the bug containing the text "Please review the content of this bug and make a decision as to whether or not this event my be streamed publicly." 

On submission, the form must trigger review requests for "[e-mail]" and the email address in the Steering Committee Contact Email: field.

Comment 1

[David Lawrence [:dkl]]

Almost done with this but had a couple questions relating the last requirements.

(In reply to Richard A Milewski[:richard] from comment #0)
> On submission, the form should attach a text file to the bug containing the
> text "Please review the content of this bug and make a decision as to
> whether or not this event my be streamed publicly." 
>
> On submission, the form must trigger review requests for
> "[e-mail]" and the email address in the Steering Committee
> Contact Email: field.

Are you asking that the flag be set against the attached text file? Can we not accomplish the same by not attaching anything and creating a flag on the bug itself with the requestee set to [e-mail]? I can create the flag and fill in the requestee automatically using the form. Attaching a file will require a little more work on the backend in addition but not impossible.

Also you ask that the steering committee email also be a requestee for the review flag. 1) we can only have one requestee per flag 2) the requestee has to be a real Bugzilla account and not any arbitrary email address and 3) we can however have more than one of the same review flag with each having a different requestee (still has to be a real Bugzilla account).

Should the steering committee email be a real Bugzilla account?

Thanks
dkl

Comment 2

[Richard A Milewski[:richard]]

The only reason I was attaching a text file was because (being a bear of very little brain) I couldn't figure out how to trigger the review requests without attaching something.   As long as [e-mail] and the steering committee member's email entered into the form get the review request, I'm happy.

So it sounds like we need to change the prompt for the SC email to explicitly ask for the Steering Committee member's BUGMAIL address.

Thanks!

Comment 3

[Richard A Milewski[:richard]]

Just got a policy change.  The Steering Committee member sign-off is no longer required, so omit item 5 in the original request.

Comment 4

[David Lawrence [:dkl]]

(In reply to Richard A Milewski[:richard] from comment #3)
> Just got a policy change.  The Steering Committee member sign-off is no
> longer required, so omit item 5 in the original request.

Ok. But we still need the pr-review flag to be set to ? with the requestee of [e-mail], correct?

dkl

Comment 5

[David Lawrence [:dkl]]

Assuming that the answer to my question in comment 4 is yes, I have pushed what I have so far to our testing server for your feedback.

https://bugzilla-stage-tip.mozilla.org/form.brownbag

dkl

Comment 6

[Richard A Milewski[:richard]]

Sorry to be so slow... The answer to the question in comment 4 is indeed "yes".

A couple of small problems:
   
* The "Show on Large Screens..." widgets should be checkboxes not radio buttons.
      
* The time zone should default to UTC not UTC+8. (...or better yet, can we have a dummy default that says "set time zone"?)


...and some things I didn't ask for in the original bug but should have:

* Let's change the title to "Event Request"

* And the line at the top to read:  "Event Requeest: Please use this form to schedule an event in any of the Mozilla Common Spaces."

Not sure the visibility line is correct.  Aren't these public unless the "Viewed by Public" radio button is set to no, in which case they're MoCo confidential?

Comment 7

[David Lawrence [:dkl]]

Thanks for the review. I have committed a new test version to:

https://bugzilla-stage-tip.mozilla.org/form.brownbag

dkl

Comment 8

[Richard A Milewski[:richard]]

Looks good except for a couple of nits:

* When viewed in a full-width window on a 1920x1280 display, the textarea for the Description is rendered to the right of the "Please describe..." text rather than under it.  

* There is an extra colon after "Special Requirements".

...and should the form on the staging server work?   I get a 500 if I submit it.

Comment 9

[David Lawrence [:dkl]]

(In reply to Richard A Milewski[:richard] from comment #8)
> Looks good except for a couple of nits:
> 
> * When viewed in a full-width window on a 1920x1280 display, the textarea
> for the Description is rendered to the right of the "Please describe..."
> text rather than under it.  
> 
> * There is an extra colon after "Special Requirements".
> 
> ...and should the form on the staging server work?   I get a 500 if I submit
> it.

I have pushed fixed to bugzilla-stage-tip.mozilla.org for the issues mentioned. Once they are there I will try to see about the 500 error again.

dkl

Comment 10

[Richard A Milewski[:richard]]

Another nit.  UTC+11 appears twice on the list.

...and I believe our office in Auckland NZ is actually UTC+13, isn't it?

Comment 11

[:glob ✱]

(In reply to Richard A Milewski[:richard] from comment #10)
> ...and I believe our office in Auckland NZ is actually UTC+13, isn't it?

during dst, yes.  good catch :)  for completeness we should do -14 through +14

Comment 12

[David Lawrence [:dkl]]

(In reply to Byron Jones ‹:glob› from comment #11)
> (In reply to Richard A Milewski[:richard] from comment #10)
> > ...and I believe our office in Auckland NZ is actually UTC+13, isn't it?
> 
> during dst, yes.  good catch :)  for completeness we should do -14 through
> +14

I have updated the form. I still have not had a chance to find out why the form is erroring on bugzilla-stage-tip.mozilla.org but it works fine on my local instance. If you are happy with the form I can try to get it out in our next code push next week.

dkl

Comment 13

[:glob ✱]

(In reply to David Lawrence [:dkl] from comment #12)
> I have updated the form. I still have not had a chance to find out why the
> form is erroring on bugzilla-stage-tip.mozilla.org 

i asked ashish to reset the permissions so we can see the logs:

[error] Can't call method "groups_in" on an undefined value at /data/www/bugzilla.mozilla.org/extensions/Push/Extension.pm line 110

i've filed bug 778614 to address this problem, which i'll look at probably later today.

Comment 14

[:glob ✱]

(In reply to Byron Jones ‹:glob› from comment #13)
> i've filed bug 778614 to address this problem, which i'll look at probably
> later today.

fix has been committed.

Comment 15

[David Lawrence [:dkl]]

Thanks glob. Richard, I was able to submit a new ticket now. Can you please do your final verification on this using our test instance, and we can get this pushed out this week.

thanks
dkl

Comment 16

[Richard A Milewski[:richard]]

Looks good David!   Thank you!   I think we're good to go.

Comment 17

[David Lawrence [:dkl]]

Cool.

Committing to: bzr+ssh://[e-mail]/bmo/4.0
modified extensions/BMO/template/en/default/bug/create/create-brownbag.html.tmpl
Committed revision 8258.

Committing to: bzr+ssh://[e-mail]/bmo/4.2
modified extensions/BMO/template/en/default/bug/create/create-brownbag.html.tmpl
Committed revision 8269