773830 - ###!!! ABORT: attempt to initialize OOP crash reporter before in-process crashreporter!: 'gExceptionHandler != NULL'

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

When launching subprocess with crashreporter disabled (but --enable-crashreporter).

Forgot CrashReporter::GetEnabled().

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Check GetEnabled() before OOPInit()

This is hosing all local b2g devs.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Check GetEnabled() before OOPInit(), v1.1

Missed a spot.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/mozilla-central/rev/08c5d1085a44

Comment 4

[Benjamin Smedberg]

Comment on attachment 642103 [details] [diff] [review]
Check GetEnabled() before OOPInit(), v1.1

Sorry about that! thanks for the quick turnaround.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 771251
User impact if declined: B2G noworkee (assuming we take bug 771251)
Testing completed (on m-c, etc.): verified via engineers being unstuck
Basically no-risk.

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 642103 [details] [diff] [review]
Check GetEnabled() before OOPInit(), v1.1

[Triage Comment]
Approving for Beta 15 along with the other bugs blocking bug 771251.

Comment 6

[Benjamin Smedberg]

https://hg.mozilla.org/releases/mozilla-beta/rev/30c2a881b7d6

Firefox 15 wasn't really affected... ;-)

Comment 7

[Ioana (away)]

Are there any reliable STR QA can verify this bug with?

Comment 8

[Benjamin Smedberg]

No. This is a B2G bug and prevented apps from starting at all.