Fix build warnings under content/

RESOLVED FIXED in mozilla17

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Tracking

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 642120 [details] [diff] [review]
Patch
Attachment #642120 - Flags: review?(jonas)
David, do you think you could try to add FAIL_ON_WARNINGS = 1 at some places in content/ subdirectories?
(Assignee)

Comment 3

5 years ago
Created attachment 643524 [details] [diff] [review]
Patch
Attachment #642120 - Attachment is obsolete: true
Attachment #642120 - Flags: review?(jonas)
Attachment #643524 - Flags: review?(mounir)
Comment on attachment 643524 [details] [diff] [review]
Patch

Review of attachment 643524 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the nit below fixed.

BTW, make sure to send this to try with "-p all", "-p macosx" isn't going to be enough.

::: content/base/src/nsContentIterator.cpp
@@ +1199,5 @@
>    PRInt32 endOffset = mRange->EndOffset();
>    MOZ_ASSERT(mCommonParent && startParent && endParent);
>    // Bug 767169
> +  MOZ_ASSERT((PRUint32)startOffset <= startParent->Length() &&
> +             (PRUint32)endOffset <= endParent->Length());

PRUint32(foo) is more C++'y.
Attachment #643524 - Flags: review?(mounir) → review+
(Assignee)

Comment 5

5 years ago
Pushed with your comment.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0dc2d401d71
https://hg.mozilla.org/mozilla-central/rev/a0dc2d401d71
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17

Updated

5 years ago
Duplicate of this bug: 755037
You need to log in before you can comment on or make changes to this bug.