Closed Bug 773866 Opened 8 years ago Closed 8 years ago

Clicking on the jobname should set a jobname filter

Categories

(Tree Management Graveyard :: TBPL, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
I often set a filter on TBPL by copying the job name from the footer and pasting it into the "filters" popup.  This patch just adds an unobtrusive shortcut for that action:  Clicking on the job name in the footer instantly creates a filter.
Attachment #642138 - Flags: review?(bmo)
Attached patch patch v2Splinter Review
I forgot to use escapeAttribute().
Attachment #642138 - Attachment is obsolete: true
Attachment #642138 - Flags: review?(bmo)
Attachment #642142 - Flags: review?(bmo)
Comment on attachment 642142 [details] [diff] [review]
patch v2

This is brilliant, will save so much copying and pasting :-D

On the whole seems fine (tested locally and works for me). Only things are:
* The two text-decoration rules seem redundant, unless I'm missing something?
* I'm 50:50 between having the link colour left more obviously that of a link (ie no color: inherit; so this new feature is more discoverable) and what you've implemented here. Don't really mind either way, so happy for you to make the call.
Attachment #642142 - Flags: review?(bmo) → review+
(In reply to Ed Morley [:edmorley] from comment #2)
> * The two text-decoration rules seem redundant, unless I'm missing something?

You're right.  Removed.

> * I'm 50:50 between having the link colour left more obviously that of a
> link (ie no color: inherit; so this new feature is more discoverable) and
> what you've implemented here. Don't really mind either way, so happy for you
> to make the call.

I removed the color:inherit to make it a blue link; I think you're right about it being more discoverable, and the visual change is not too jarring.

https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/a9d078374c48
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Depends on: 777105
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.