773866 - Clicking on the jobname should set a jobname filter

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, enhancement)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

I often set a filter on TBPL by copying the job name from the footer and pasting it into the "filters" popup.  This patch just adds an unobtrusive shortcut for that action:  Clicking on the job name in the footer instantly creates a filter.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch v2

I forgot to use escapeAttribute().

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 642142 [details] [diff] [review]
patch v2

This is brilliant, will save so much copying and pasting :-D

On the whole seems fine (tested locally and works for me). Only things are:
* The two text-decoration rules seem redundant, unless I'm missing something?
* I'm 50:50 between having the link colour left more obviously that of a link (ie no color: inherit; so this new feature is more discoverable) and what you've implemented here. Don't really mind either way, so happy for you to make the call.

Comment 3

[Matt Brubeck (:mbrubeck)]

(In reply to Ed Morley [:edmorley] from comment #2)
> * The two text-decoration rules seem redundant, unless I'm missing something?

You're right.  Removed.

> * I'm 50:50 between having the link colour left more obviously that of a
> link (ie no color: inherit; so this new feature is more discoverable) and
> what you've implemented here. Don't really mind either way, so happy for you
> to make the call.

I removed the color:inherit to make it a blue link; I think you're right about it being more discoverable, and the visual change is not too jarring.

https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/a9d078374c48