Remove libs rules from browser/components/sessionstore/src/Makefile.in

RESOLVED FIXED in Firefox 17

Status

()

Firefox
Session Restore
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 642195 [details] [diff] [review]
Patch v1
Attachment #642195 - Flags: review?(ted.mielczarek)
Comment on attachment 642195 [details] [diff] [review]
Patch v1

Review of attachment 642195 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/sessionstore/src/Makefile.in
@@ +31,1 @@
>  	SessionStore.jsm \

Fix the indent while you're here?

::: config/rules.mk
@@ +1392,5 @@
>  ################################################################################
> +# Copy each element of EXTRA_JS_MODULES to JS_MODULES_PATH, or
> +# $(FINAL_TARGET)/modules if that isn't defined.
> +ifndef JS_MODULES_PATH
> +JS_MODULES_PATH := $(FINAL_TARGET)/modules

You could just write this as
JS_MODULES_PATH ?= $(FINAL_TARGET)/modules
Attachment #642195 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/c6ae36a7f8a9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17

Comment 4

5 years ago
Backed out with the mass tree revert to get rid of the OS X M5 orange:
https://hg.mozilla.org/mozilla-central/rev/c801b99d726f
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6318b897437
https://hg.mozilla.org/mozilla-central/rev/d6318b897437
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Duplicate of this bug: 775338
You need to log in before you can comment on or make changes to this bug.