773944 - java.lang.ClassCastException: org.mozilla.gecko.AwesomeBarTab$AwesomeEntryViewHolder cannot be cast to org.mozilla.gecko.AllPagesTab$SearchEntryViewHolder at org.mozilla.gecko.AllPagesTab$AwesomeBarCursorAdapter.getView(AllPagesTab.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Scoobidiver (away)]

There are two crashes, one in 16.0a1/20120706 and one in 16.0a1/20120713, bp-45b36386-2cf8-489e-a309-803782120714.

java.lang.ClassCastException: org.mozilla.gecko.AwesomeBarTab$AwesomeEntryViewHolder cannot be cast to org.mozilla.gecko.AllPagesTab$SearchEntryViewHolder
	at org.mozilla.gecko.AllPagesTab$AwesomeBarCursorAdapter.getView(AllPagesTab.java:325)
	at android.widget.AbsListView.obtainView(AbsListView.java:2039)
	at android.widget.ListView.makeAndAddView(ListView.java:1772)
	at android.widget.ListView.fillSpecific(ListView.java:1318)
	at android.widget.ListView.layoutChildren(ListView.java:1603)
	at android.widget.AbsListView.onLayout(AbsListView.java:1890)
	at android.view.View.layout(View.java:11278)
	at android.view.ViewGroup.layout(ViewGroup.java:4224)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:431)
	at android.view.View.layout(View.java:11278)
	at android.view.ViewGroup.layout(ViewGroup.java:4224)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1628)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1486)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1399)
	at android.view.View.layout(View.java:11278)
	at android.view.ViewGroup.layout(ViewGroup.java:4224)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:431)
	at android.view.View.layout(View.java:11278)
	at android.view.ViewGroup.layout(ViewGroup.java:4224)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1628)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1486)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1399)
	at android.view.View.layout(View.java:11278)
	at android.view.ViewGroup.layout(ViewGroup.java:4224)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:431)
	at android.view.View.layout(View.java:11278)
	at android.view.ViewGroup.layout(ViewGroup.java:4224)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1628)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1486)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1399)
	at android.view.View.layout(View.java:11278)
	at android.view.ViewGroup.layout(ViewGroup.java:4224)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:431)
	at android.view.View.layout(View.java:11278)
	at android.view.ViewGroup.layout(ViewGroup.java:4224)
	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1489)
	at android.view.ViewRootImpl.handleMessage(ViewRootImpl.java:2442)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4575)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:789)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:556)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.ClassCastException%3A+org.mozilla.gecko.AwesomeBarTab%24AwesomeEntryViewHolder+cannot+be+cast+to+org.mozilla.gecko.AllPagesTab%24SearchEntryViewHolder+at+org.mozilla.gecko.AllPagesTab%24AwesomeBarCursorAdapter.getView%28AllPagesTab.java%29

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Check view tag's type before casting to viewholder

This shouldn't be necessary, but we're doing something wrong somewhere, and this is a band-aid until we know what the cause is.

Comment 3

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/821258fa9f9c

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 702065 [details] [diff] [review]
Check view tag's type before casting to viewholder

[Approval Request Comment]
Bug caused by (feature/regressing bug #): unknown
User impact if declined: occasional crash on awesomescreen
Testing completed (on m-c, etc.): just landed m-i
Risk to taking this patch (and alternatives if risky): very low risk - just adds instanceof check
String or UUID changes made by this patch: none

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 702065 [details] [diff] [review]
Check view tag's type before casting to viewholder

Not a critical fix for beta, given this is a longstanding issue. Approving for Aurora.

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/821258fa9f9c

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c26befa04d80