toolkit/crashreporter/test/unit_ipc/xpcshell.ini is included with an invalid condition

RESOLVED FIXED in mozilla18

Status

()

Product:
Core
Component:
IPC
RESOLVED FIXED
Reported:
6 years ago
Modified:
6 years ago

People

(Reporter: Unfocused, Assigned: jdm)

Tracking

Version:
unspecified
Target:
mozilla18
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Fix up invalid syntax and configurations in xpcshell.ini.
1.04 KB, patch
jmaher
: review+
Details | Diff | Splinter Review
(Reporter)

Description

•
6 years ago 
toolkit/crashreporter/test/unit_ipc/xpcshell.ini is included here:

https://hg.mozilla.org/mozilla-central/annotate/6f14db95942b/testing/xpcshell/xpcshell.ini#l103

With the condition:
  skip-if.os == "linux" || !crashreporter

Which AFAIK is invalid syntax, and needs to be the following for it to work:
  skip-if = os == "linux" || !crashreporter


However, that was landed 9 months ago. So is the intent of the condition valid, or should it just be removed?
(Assignee)

Comment 1

•
6 years ago 
Created attachment 642230 [details] [diff] [review]
Fix up invalid syntax and configurations in xpcshell.ini.

I did some testing and found that the conditions as applied don't do anything. Therefore, these modifications should have no effective difference.
Attachment #642230 - Flags: review?(jmaher)
Assignee: nobody → josh

Comment 2

•
6 years ago 
Comment on attachment 642230 [details] [diff] [review]
Fix up invalid syntax and configurations in xpcshell.ini.

Review of attachment 642230 [details] [diff] [review]:
-----------------------------------------------------------------

thanks
Attachment #642230 - Flags: review?(jmaher) → review+

Comment 4

•
6 years ago 
https://hg.mozilla.org/mozilla-central/rev/054016215c5e
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.