The default bug view has changed. See this FAQ.

Fix calling convention conflicts of NPN_xxx funciton pointer

RESOLVED FIXED in mozilla17

Status

()

Core
Plug-ins
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: KO Myung-Hun, Assigned: KO Myung-Hun)

Tracking

Trunk
mozilla17
x86
OS/2
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

5 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20100101 Firefox/13.0.1
Build ID: 20120614114901
(Assignee)

Comment 1

5 years ago
NPN_xxx function pointers should use NP_CALLBACK calling convention.
(Assignee)

Comment 2

5 years ago
Created attachment 642225 [details] [diff] [review]
Prepend NP_CALLBACK to NPN_xxx function pointers
Attachment #642225 - Flags: review?(daveryeo)
(Assignee)

Updated

5 years ago
OS: Windows 7 → OS/2
Hardware: x86_64 → x86
Comment on attachment 642225 [details] [diff] [review]
Prepend NP_CALLBACK to NPN_xxx function pointers

The NPAPI headers are now imported directly from the npapi-sdk project shared between vendors. Any patches to this need to be directed upstream.
Attachment #642225 - Flags: review?(daveryeo) → review-
http://code.google.com/p/npapi-sdk/
(Assignee)

Comment 5

5 years ago
Thanks for your advice.

I've submitted a patch for npfunctions.h to the upstream.

And I attach a patch for nsNPAPIPlugin.h, here.
(Assignee)

Comment 6

5 years ago
Created attachment 642246 [details] [diff] [review]
Remove NP_CALLBACK from nsNPAPIPlugin.h
Attachment #642246 - Flags: review?(benjamin)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 642246 [details] [diff] [review]
Remove NP_CALLBACK from nsNPAPIPlugin.h

I thought we removed NP_CALLBACK on purpose, so I'm going to bump this to josh.
Attachment #642246 - Flags: review?(benjamin) → review?(joshmoz)

Comment 8

5 years ago
Comment on attachment 642246 [details] [diff] [review]
Remove NP_CALLBACK from nsNPAPIPlugin.h

Review of attachment 642246 [details] [diff] [review]:
-----------------------------------------------------------------

We don't need to change this, we're not defining NP_CALLBACK in the NPAPI headers.
Attachment #642246 - Flags: review?(joshmoz) → review-
(Assignee)

Comment 9

5 years ago
Created attachment 651715 [details] [diff] [review]
Define NP_CALLBACK as NP_LOADDS
Attachment #651715 - Flags: review?(joshmoz)

Updated

5 years ago
Attachment #651715 - Flags: review?(joshmoz) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Comment on attachment 642225 [details] [diff] [review]
Prepend NP_CALLBACK to NPN_xxx function pointers

Please mark obsolete patches as such before adding checkin-needed to a bug.
Attachment #642225 - Attachment is obsolete: true
Attachment #642246 - Attachment is obsolete: true
This also fails to build.

https://tbpl.mozilla.org/php/getParsedLog.php?id=14448366&tree=Try

PluginModuleParent.cpp
cc1plus: warnings being treated as errors
In file included from /builds/slave/try-lnx/build/dom/plugins/ipc/PluginModuleChild.cpp:46:0:
/builds/slave/try-lnx/build/dom/plugins/ipc/../base/nsNPAPIPlugin.h:23:0: error: "NP_CALLBACK" redefined
../../../dist/include/mozilla/plugins/PluginModuleChild.h:46:0: note: this is the location of the previous definition
cc1plus: warnings being treated as errors
In file included from /builds/slave/try-lnx/build/dom/plugins/ipc/PluginScriptableObjectUtils.h:11:0,
                 from /builds/slave/try-lnx/build/dom/plugins/ipc/PluginIdentifierParent.cpp:12:
/builds/slave/try-lnx/build/dom/plugins/ipc/PluginModuleChild.h:46:0: error: "NP_CALLBACK" redefined
/builds/slave/try-lnx/build/dom/plugins/ipc/../base/nsNPAPIPlugin.h:23:0: note: this is the location of the previous definition

Please include a link to passing Try results when requesting checkin again.
Keywords: checkin-needed
(Assignee)

Comment 12

5 years ago
Created attachment 652662 [details] [diff] [review]
Define NP_CALLBACK as NP_LOADDS v2
Attachment #651715 - Attachment is obsolete: true
Attachment #652662 - Flags: review?(joshmoz)

Updated

5 years ago
Attachment #652662 - Flags: review?(joshmoz) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Green on Try. (The Windows test failure is unrelated to this patch)
https://tbpl.mozilla.org/?tree=Try&rev=bb4178a63464

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a1ab48fc876
Assignee: nobody → komh
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7a1ab48fc876
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.