Last Comment Bug 773961 - 'Browse' sometimes does not work
: 'Browse' sometimes does not work
Status: RESOLVED FIXED
NPOTB, OS/2 only file.
:
Product: Core Graveyard
Classification: Graveyard
Component: Widget: OS/2 (show other bugs)
: Trunk
: x86 OS/2
: -- normal (vote)
: mozilla17
Assigned To: KO Myung-Hun
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-14 07:17 PDT by KO Myung-Hun
Modified: 2014-12-09 11:27 PST (History)
9 users (show)
ryanvm: in‑testsuite-
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Fix a browse problem (2.00 KB, patch)
2012-07-14 07:20 PDT, KO Myung-Hun
dave.r.yeo: review+
Details | Diff | Splinter Review

Description KO Myung-Hun 2012-07-14 07:17:43 PDT
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20100101 Firefox/13.0.1
Build ID: 20120614114901
Comment 1 KO Myung-Hun 2012-07-14 07:19:35 PDT
Sometimes, initialDir.get() return a path with '\' at last. In this case, WinFileDlg() fails because of double '\' in a path.
Comment 2 KO Myung-Hun 2012-07-14 07:20:59 PDT
Created attachment 642227 [details] [diff] [review]
Fix a browse problem
Comment 3 Dave Yeo 2012-07-14 11:26:44 PDT
Comment on attachment 642227 [details] [diff] [review]
Fix a browse problem

I wonder if this will also fix bug#573220. Did your IME test build also have this fix? If so we should request that someone suffering from #573220 test then perhaps mark it as a duplicate of this bug.
Comment 4 KO Myung-Hun 2012-07-14 18:35:04 PDT
I've updated IME test build because I'm not sure it contains this patch. ^^

Try this,

    http://www.ecomstation.co.kr/komh/testcase/firefox-10.0.6esrpre.en-US.os2.zip
Comment 5 Peter Kruithof 2012-07-17 09:55:18 PDT
Tried it ,but no solution for bug#573220 from which i am suffering for a long time.
But i do not have a browse problem
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-07-21 06:22:39 PDT
Comment on attachment 642227 [details] [diff] [review]
Fix a browse problem

You can just use checkin-needed when you need something checked in.
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-07-21 11:36:05 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/defbe00ca091

I inadvertently checked this in with my name on it because I didn't notice that the attached patch was missing the right metadata for it. As a reminder, please follow the directions below for future patches so that these types of problems don't occur. Thanks and my apologies.
https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in
Comment 8 Ryan VanderMeulen [:RyanVM] 2012-07-21 14:42:33 PDT
https://hg.mozilla.org/mozilla-central/rev/defbe00ca091
Comment 9 KO Myung-Hun 2012-07-22 05:09:17 PDT
(In reply to Ryan VanderMeulen from comment #6)
> Comment on attachment 642227 [details] [diff] [review]
> Fix a browse problem
> 
> You can just use checkin-needed when you need something checked in.

I learned a new thing, again. ^^

(In reply to Ryan VanderMeulen from comment #7)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/defbe00ca091
> 
> I inadvertently checked this in with my name on it because I didn't notice
> that the attached patch was missing the right metadata for it. As a
> reminder, please follow the directions below for future patches so that
> these types of problems don't occur. Thanks and my apologies.
> https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in

I attached the patch from .hg/patches directly.

In this case, metadatas such as username seem not to be generated automatically.

I'll confirm this before submitting a patch, later.

Thanks.
Comment 10 Ryan VanderMeulen [:RyanVM] 2012-07-22 07:03:21 PDT
(In reply to KO Myung-Hun from comment #9)
> I attached the patch from .hg/patches directly.
> 
> In this case, metadatas such as username seem not to be generated
> automatically.
> 

It should if you set |qnew = -U| under [defaults]
Comment 11 KO Myung-Hun 2012-07-22 19:08:36 PDT
(In reply to Ryan VanderMeulen from comment #10)
> (In reply to KO Myung-Hun from comment #9)
> > I attached the patch from .hg/patches directly.
> > 
> > In this case, metadatas such as username seem not to be generated
> > automatically.
> > 
> 
> It should if you set |qnew = -U| under [defaults]

Strange, I already did it.

Hmm...

Maybe it had no effects because a patch had been made before it was set.

Thanks.

Note You need to log in before you can comment on or make changes to this bug.