Last Comment Bug 774027 - Add hidden:true to selected GCLI commands
: Add hidden:true to selected GCLI commands
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: Trunk
: All All
: P1 normal (vote)
: Firefox 16
Assigned To: Joe Walker [:jwalker] (needinfo me or ping on irc)
:
: Brian Grinstead [:bgrins]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-14 20:24 PDT by Joe Walker [:jwalker] (needinfo me or ping on irc)
Modified: 2012-07-16 05:26 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (131.49 KB, patch)
2012-07-14 20:32 PDT, Joe Walker [:jwalker] (needinfo me or ping on irc)
no flags Details | Diff | Splinter Review
v2 (1.17 KB, patch)
2012-07-15 02:03 PDT, Joe Walker [:jwalker] (needinfo me or ping on irc)
mihai.sucan: review+
Details | Diff | Splinter Review

Description Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-07-14 20:24:53 PDT
echo (not that useful)
cmd (should be enabled only with the pref)
jsb (until long param list doesn't cause problems)
Comment 1 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-07-14 20:32:54 PDT
Created attachment 642324 [details] [diff] [review]
v1
Comment 2 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-07-15 02:03:41 PDT
Created attachment 642354 [details] [diff] [review]
v2

Just the one file now
Comment 3 Michael Ratcliffe [:miker] [:mratcliffe] 2012-07-15 04:59:09 PDT
Adding hidden:true makes sense here for jsb, at least until we have a working way of hiding the params. They didn't push any buttons off the screen on my PC but on a narrow screen I can see this happening.

It is a shame we couldn't have just hidden a few params instead.
Comment 4 Ed Morley [:emorley] 2012-07-16 05:26:51 PDT
https://hg.mozilla.org/mozilla-central/rev/bbaf6eac575e

Note You need to log in before you can comment on or make changes to this bug.