Last Comment Bug 774041 - silence warning about unused private field
: silence warning about unused private field
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla17
Assigned To: Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
:
Mentors:
Depends on:
Blocks: clang
  Show dependency treegraph
 
Reported: 2012-07-14 21:06 PDT by Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
Modified: 2012-07-17 02:14 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
silence warning about unused private field (341 bytes, patch)
2012-07-14 21:06 PDT, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
benjamin: review+
Details | Diff | Splinter Review

Description Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2012-07-14 21:06:29 PDT
Created attachment 642334 [details] [diff] [review]
silence warning about unused private field
Comment 1 Benjamin Smedberg AWAY UNTIL 2-AUG-2016 [:bsmedberg] 2012-07-16 07:41:46 PDT
Comment on attachment 642334 [details] [diff] [review]
silence warning about unused private field

I think this should at least be protected; we are trying to make a structure which is the same size as nsSubstring so that the internal string code can use this buffer as an internal string. r=me to make it protected
Comment 2 Ed Morley [:emorley] 2012-07-16 11:16:43 PDT
Didn't make it to mozilla-central before the uplift (merge was blocked on bug 774259). Adjusting milestone accordingly.
Comment 3 Ed Morley [:emorley] 2012-07-17 02:14:05 PDT
https://hg.mozilla.org/mozilla-central/rev/24baaf912f92

Note You need to log in before you can comment on or make changes to this bug.