Last Comment Bug 774057 - Hiding of jsb breaks unit tests
: Hiding of jsb breaks unit tests
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: Trunk
: All All
: P1 normal (vote)
: Firefox 16
Assigned To: Joe Walker [:jwalker] (needinfo me or ping on irc)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-15 03:11 PDT by Joe Walker [:jwalker] (needinfo me or ping on irc)
Modified: 2012-07-16 05:26 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (131.18 KB, patch)
2012-07-15 03:17 PDT, Joe Walker [:jwalker] (needinfo me or ping on irc)
no flags Details | Diff | Splinter Review
v2 (876 bytes, patch)
2012-07-15 03:23 PDT, Joe Walker [:jwalker] (needinfo me or ping on irc)
mihai.sucan: review+
Details | Diff | Splinter Review
v3 (1.37 KB, patch)
2012-07-15 03:49 PDT, Joe Walker [:jwalker] (needinfo me or ping on irc)
mihai.sucan: review+
Details | Diff | Splinter Review

Description Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-07-15 03:11:34 PDT

    
Comment 1 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-07-15 03:17:51 PDT
Created attachment 642358 [details] [diff] [review]
v1
Comment 2 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-07-15 03:23:32 PDT
Created attachment 642359 [details] [diff] [review]
v2

My build process was including extra files, v2 removes them.
Comment 3 Mihai Sucan [:msucan] 2012-07-15 03:27:07 PDT
Comment on attachment 642359 [details] [diff] [review]
v2

Shouldn't the test run successfully even if the command is hidden?
Comment 4 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-07-15 03:49:50 PDT
Created attachment 642361 [details] [diff] [review]
v3

Additional commented out test
Comment 5 Mihai Sucan [:msucan] 2012-07-15 03:52:14 PDT
Comment on attachment 642361 [details] [diff] [review]
v3

see comment 3
Comment 6 Ed Morley [:emorley] 2012-07-16 05:26:47 PDT
https://hg.mozilla.org/mozilla-central/rev/e7e48bd97c69

Note You need to log in before you can comment on or make changes to this bug.