Closed
Bug 774140
Opened 13 years ago
Closed 13 years ago
Remove code duplication for IsVistaOrLater
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: bbondy, Assigned: bbondy)
References
Details
Attachments
(1 file)
|
5.05 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
In Bug 773518 I once again needed to use a check for IsVistaOrLater so I decided to refactor all of this into nsWindowsHelpers.h with a header only implementation.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #642455 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 2•13 years ago
|
||
This is passing tests from a push to try by the way.
|
||
Comment 3•13 years ago
|
||
Comment on attachment 642455 [details] [diff] [review]
Patch v1.
Seems to me that we want this in a .cpp file if we're going to use it any number of times, but I guess this is at least as good as what we've got now.
Attachment #642455 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
I did it that way so that we can use it in various libraries without having linking errors. Also you can use it without even linking to anything at all (as is the rest of nsWindowsHelpers.h).
|
|
Assignee | |
Comment 5•13 years ago
|
||
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•