Last Comment Bug 774140 - Remove code duplication for IsVistaOrLater
: Remove code duplication for IsVistaOrLater
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: mozilla17
Assigned To: Brian R. Bondy [:bbondy]
:
:
Mentors:
Depends on:
Blocks: 773518
  Show dependency treegraph
 
Reported: 2012-07-15 18:03 PDT by Brian R. Bondy [:bbondy]
Modified: 2012-07-26 14:07 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1. (5.05 KB, patch)
2012-07-15 18:05 PDT, Brian R. Bondy [:bbondy]
benjamin: review+
Details | Diff | Splinter Review

Description Brian R. Bondy [:bbondy] 2012-07-15 18:03:35 PDT
In Bug 773518 I once again needed to use a check for IsVistaOrLater so I decided to refactor all of this into nsWindowsHelpers.h with a header only implementation.
Comment 1 Brian R. Bondy [:bbondy] 2012-07-15 18:05:32 PDT
Created attachment 642455 [details] [diff] [review]
Patch v1.
Comment 2 Brian R. Bondy [:bbondy] 2012-07-19 07:47:41 PDT
This is passing tests from a push to try by the way.
Comment 3 Benjamin Smedberg [:bsmedberg] 2012-07-24 09:01:26 PDT
Comment on attachment 642455 [details] [diff] [review]
Patch v1.

Seems to me that we want this in a .cpp file if we're going to use it any number of times, but I guess this is at least as good as what we've got now.
Comment 4 Brian R. Bondy [:bbondy] 2012-07-24 09:03:39 PDT
I did it that way so that we can use it in various libraries without having linking errors.  Also you can use it without even linking to anything at all (as is the rest of nsWindowsHelpers.h).
Comment 5 Brian R. Bondy [:bbondy] 2012-07-26 08:05:23 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/33b40911b9ba
Comment 6 Matt Brubeck (:mbrubeck) 2012-07-26 14:07:53 PDT
https://hg.mozilla.org/mozilla-central/rev/33b40911b9ba

Note You need to log in before you can comment on or make changes to this bug.