Closed Bug 774140 Opened 8 years ago Closed 8 years ago

Remove code duplication for IsVistaOrLater

Categories

(Core :: XPCOM, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: bbondy, Assigned: bbondy)

References

Details

Attachments

(1 file)

In Bug 773518 I once again needed to use a check for IsVistaOrLater so I decided to refactor all of this into nsWindowsHelpers.h with a header only implementation.
Blocks: 773518
Attached patch Patch v1.Splinter Review
Attachment #642455 - Flags: review?(benjamin)
This is passing tests from a push to try by the way.
Comment on attachment 642455 [details] [diff] [review]
Patch v1.

Seems to me that we want this in a .cpp file if we're going to use it any number of times, but I guess this is at least as good as what we've got now.
Attachment #642455 - Flags: review?(benjamin) → review+
I did it that way so that we can use it in various libraries without having linking errors.  Also you can use it without even linking to anything at all (as is the rest of nsWindowsHelpers.h).
https://hg.mozilla.org/mozilla-central/rev/33b40911b9ba
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.