Remove code duplication for IsVistaOrLater

RESOLVED FIXED in mozilla17

Status

()

Core
XPCOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bbondy, Assigned: bbondy)

Tracking

Trunk
mozilla17
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
In Bug 773518 I once again needed to use a check for IsVistaOrLater so I decided to refactor all of this into nsWindowsHelpers.h with a header only implementation.
(Assignee)

Updated

5 years ago
Blocks: 773518
(Assignee)

Comment 1

5 years ago
Created attachment 642455 [details] [diff] [review]
Patch v1.
Attachment #642455 - Flags: review?(benjamin)
(Assignee)

Comment 2

5 years ago
This is passing tests from a push to try by the way.
Comment on attachment 642455 [details] [diff] [review]
Patch v1.

Seems to me that we want this in a .cpp file if we're going to use it any number of times, but I guess this is at least as good as what we've got now.
Attachment #642455 - Flags: review?(benjamin) → review+
(Assignee)

Comment 4

5 years ago
I did it that way so that we can use it in various libraries without having linking errors.  Also you can use it without even linking to anything at all (as is the rest of nsWindowsHelpers.h).
(Assignee)

Comment 5

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/33b40911b9ba
https://hg.mozilla.org/mozilla-central/rev/33b40911b9ba
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.