774240 - data URI parsing mis-detects "base64" parameter as extension

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Julian Reschke]

"data" URIs (RFC 2397) allow extension parameters; they could be called "base64" but must not be confused with the "base64" extension.

For instance;

  data:text/plain;base64,...

*is* the base64 extension, while

  data:text/plain;base64=xy,...

is not (as indicated by the "=" sign).

See test case:

  <http://greenbytes.de/tech/tc/datauri/#base64param>

This works properly in Chrome and Opera.

Comment 1

[felix_moeller]

Attachment: Proposed patch, including test case

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 642551 [details] [diff] [review]
Proposed patch, including test case

Change the two constant strings to single a #define BASE64_URI_TAG ";base64" (or some such name), and r+

Comment 3

[felix_moeller]

Attachment: proposed patch

thanks for the review Randell!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eac3221e3e86

Thanks for the patch, Felix! One request - for future patches, please follow the directions below. It makes life easier for those committing on your behalf. Thanks again!
https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/eac3221e3e86