The default bug view has changed. See this FAQ.

improve DNS logging

RESOLVED FIXED in mozilla17

Status

()

Core
Networking: DNS
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Josh Aas, Assigned: Josh Aas)

Tracking

Trunk
mozilla17
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 642578 [details] [diff] [review]
fix v1.0

I'd like to make some modest improvements to DNS logging.
Attachment #642578 - Flags: review?(sworkman)
Comment on attachment 642578 [details] [diff] [review]
fix v1.0

Review of attachment 642578 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=me.

::: netwerk/dns/nsHostResolver.cpp
@@ +950,5 @@
>  
>  void
>  nsHostResolver::ThreadFunc(void *arg)
>  {
> +    LOG(("DNS lookup thread starting execution.\n"));

Would it be overkill to get the thread id (PR_GetThreadID) for the logs in ThreadFunc? Called functions don't look like they have logs.
Attachment #642578 - Flags: review?(sworkman) → review+
PR_LOG adds the thread id in its output, doesn't it?
Oh! That's what that is :) Then never mind what I wrote.
(Assignee)

Comment 4

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/7fe11a265ac5
:-) See http://mxr.mozilla.org/mozilla-central/source/nsprpub/pr/src/io/prlog.c#456

The first number is the PRThread->id, the second number is the PRThread*. I believe that makes the first number the OS thread ID.
Thanks Christian :)
https://hg.mozilla.org/mozilla-central/rev/7fe11a265ac5
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.