Closed
Bug 774271
Opened 13 years ago
Closed 13 years ago
improve DNS logging
Categories
(Core :: Networking: DNS, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: jaas, Assigned: jaas)
Details
Attachments
(1 file)
|
11.76 KB,
patch
|
sworkman
:
review+
|
Details | Diff | Splinter Review |
I'd like to make some modest improvements to DNS logging.
Attachment #642578 -
Flags: review?(sworkman)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 642578 [details] [diff] [review]
fix v1.0
Review of attachment 642578 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. r=me.
::: netwerk/dns/nsHostResolver.cpp
@@ +950,5 @@
>
> void
> nsHostResolver::ThreadFunc(void *arg)
> {
> + LOG(("DNS lookup thread starting execution.\n"));
Would it be overkill to get the thread id (PR_GetThreadID) for the logs in ThreadFunc? Called functions don't look like they have logs.
Attachment #642578 -
Flags: review?(sworkman) → review+
|
||
Comment 2•13 years ago
|
||
PR_LOG adds the thread id in its output, doesn't it?
|
|
||
Comment 3•13 years ago
|
||
Oh! That's what that is :) Then never mind what I wrote.
|
|
||
Comment 5•13 years ago
|
||
:-) See http://mxr.mozilla.org/mozilla-central/source/nsprpub/pr/src/io/prlog.c#456
The first number is the PRThread->id, the second number is the PRThread*. I believe that makes the first number the OS thread ID.
|
|
||
Comment 6•13 years ago
|
||
Thanks Christian :)
|
||
Comment 7•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•