774284 - Add a way to dump symbols for Gonk libraries

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[(not currently active) Ted Mielczarek]

If we're going to upload symbols for B2G builds, we should upload the symbols from the gonk system libs as well. It should be straightforward to run the symbolstore.py script on the unstripped binaries. We probably want some sort of top-level build target that does that and also runs "make buildsymbols" in the Gecko objdir as well, to pack them into one big symbol package.

Comment 1

[Andreas Gal :gal]

We should be able to capture symbols for most of gonk too right?

Comment 2

[(not currently active) Ted Mielczarek]

Anything that we build as part of the B2G build we should be able to dump symbols for. I'm mostly interested in bionic and other system libraries that are likely to show up in crash reports.

Comment 3

[(not currently active) Ted Mielczarek]

Attachment: WIP

This is a work in progress. It produces usable symbols for me, but I need to think through more of the details. This is going to interact with bug 774780 as well.

Comment 4

[Dietrich Ayala (:dietrich)]

Might be blocker for Soccorro, but not for the B2G eng deliverable, blocking-.

Comment 5

[Jason Smith [:jsmith]]

Ted - Do we need this to have usable crash reports for Firefox OS in Socorro? Would this be built into the Firefox OS implementation?

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This is work for our build / server infra, not core gecko.  In other words, the code to implement this would not ship with b2g phones themselves.

If the crashreporter/socorro team is tracking blocking-basecamp/k9o bugs here, then it may be appropriate to mark blocking wrt that team.

Comment 7

[(not currently active) Ted Mielczarek]

(In reply to Jason Smith [:jsmith] from comment #5)
> Ted - Do we need this to have usable crash reports for Firefox OS in
> Socorro? Would this be built into the Firefox OS implementation?

We do need this to have usable crash reports, but this is something that happens at build-time, not something that ships with the product.

Comment 8

[Dietrich Ayala (:dietrich)]

So is this bug in the right product/component?

Comment 9

[(not currently active) Ted Mielczarek]

The work needs to be done in the B2G repos, probably gonk-misc, not in Gecko, which is why I stuck it here. If you think it belongs elsewhere I have no objections.

Comment 10

[Dietrich Ayala (:dietrich)]

Hey Ted, how's this coming along?

Comment 11

[(not currently active) Ted Mielczarek]

I haven't had any time to work on this, I've been working on the pandaboard reimaging service for Android/B2G automation.

Comment 12

[(not currently active) Ted Mielczarek]

Sent a pull request for a very simple first cut of this (just forwarding to the existing Gecko targets):
https://github.com/mozilla-b2g/gonk-misc/pull/42

This is to unblock RelEng and let us get some symbols for dogfood builds.

Comment 13

[(not currently active) Ted Mielczarek]

That PR got merged:
https://github.com/luser/gonk-misc/commit/772591c5c2940a1af4d911b04e9d6f1b4e2eed1a

I'm going to keep this bug open for the more complete implementation which will also dump symbols from Gonk system libraries.

Comment 14

[(not currently active) Ted Mielczarek]

Attachment: simpler approach

This takes a simpler approach, building on top of the PR I mentioned above. It just uses the existing logic in the Gecko Makefiles, but passes some additional info.

Comment 15

[(not currently active) Ted Mielczarek]

I simplified that even further and submitted a new PR:
https://github.com/mozilla-b2g/gonk-misc/pull/50

Comment 16

[(not currently active) Ted Mielczarek]

Merged, I'm going to call this fixed for now:
https://github.com/mozilla-b2g/gonk-misc/commit/bd86cbf26e138eb9b8b9bfd2a6d1bbfc94864753

I'll sort out getting source info in a followup.