ScriptFactory-based builders don't seem to clobber correctly

RESOLVED FIXED

Status

Release Engineering
Release Automation
P1
critical
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: bhearsum, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
Noticed this while working on 14.0.1; the SUMS files had 13.0 checksums in them, but those .checksums files didn't exist in the candidates directory. Looking at the slave that did the work, I see:
[cltbld@linux-ix-slave39 temp]$ ls  -l linux-i686/af
total 8
-rw-r--r-- 1 cltbld cltbld 2568 Jun  1 06:07 firefox-13.0.checksums
-rw-r--r-- 1 cltbld cltbld 2616 Jul 13 15:05 firefox-14.0.1.checksums

But in the builder only 14.0.1 was downloaded:
linux-i686/af/firefox-14.0.1.checksums

I think some of our scripts need to use always clobber:
https://github.com/mozilla/build-tools/blob/master/scripts/release/generate-sums.sh#L38
https://github.com/mozilla/build-tools/blob/master/scripts/release/push-to-mirrors.sh
https://github.com/mozilla/build-tools/blob/master/scripts/release/tagging.sh

There might be others, too.
(Assignee)

Updated

6 years ago
Assignee: nobody → rail
Severity: normal → critical
Priority: -- → P1
(Assignee)

Comment 1

6 years ago
Created attachment 642982 [details] [diff] [review]
fix properties

Bad properties are passed to the scripts :/
Attachment #642982 - Flags: review?(bhearsum)
(Assignee)

Comment 2

6 years ago
Created attachment 642983 [details] [diff] [review]
use slavebuilddir
Attachment #642983 - Flags: review?(bhearsum)
(Reporter)

Comment 3

6 years ago
Comment on attachment 642982 [details] [diff] [review]
fix properties

Review of attachment 642982 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this!
Attachment #642982 - Flags: review?(bhearsum) → review+
(Reporter)

Updated

6 years ago
Attachment #642983 - Flags: review?(bhearsum) → review+
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Blocks: 777230
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.